Re: [PATCH v5 4/5] mfd: axp20x: Add support for AXP318W PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The MFD cell array `axp318_cells` hard-codes the MFD cell ID to 1 instead of using `PLATFORM_DEVID_AUTO`, violating MFD subsystem guidelines.
--

--- Patch [4]: [PATCH v5 4/5] mfd: axp20x: Add support for AXP318W PMIC ---
commit 76c82c1e91d9894a1be9b93884198b1f956c4a6b
Author: Andre Przywara <andre.przywara@arm.com>

mfd: axp20x: Add support for AXP318W PMIC

This commit adds support for the X-Powers AXP318W PMIC to the axp20x driver.
It describes the regmap and MFD bits, and exposes the regulator and interrupt
registers via I2C.

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c

[ ... ]

> @@ -1061,6 +1129,10 @@ static const struct mfd_cell axp313a_cells[] = {
>  	MFD_CELL_RES("axp313a-pek", axp313a_pek_resources),
>  };
>  
> +static const struct mfd_cell axp318_cells[] = {
> +	MFD_CELL_BASIC("axp20x-regulator", NULL, NULL, 0, 1),

[Severity: High]
Does this hard-coded MFD cell ID cause naming collisions in sysfs?

Setting the cell ID to 1 instead of using PLATFORM_DEVID_AUTO can cause
device registration to fail due to a name collision on axp20x-regulator.1
if multiple MFDs defining the same cell name and ID are instantiated on the
same system.

> +};
> +
>  static const struct mfd_cell axp717_cells[] = {
>  	MFD_CELL_NAME("axp20x-regulator"),

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-axp318-regulator-v5-0-a1afa7ee24f9@baylibre.com?part=4