From: sashiko-bot@kernel.org
To: "Bhargav Joshi" <j.bhargav.u@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema
Date: Mon, 20 Jul 2026 20:33:10 +0000 [thread overview]
Message-ID: <20260720203311.145671F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260721-ti-extcon-palmas-v1-1-cd4071f0b9d9@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree node name in the example uses an underscore (`palmas_usb`), which violates standard DT naming conventions. It should use a hyphen (e.g., `palmas-usb` or a generic name like `usb-comparator`). This change introduces a `dtc` warning (`node_name_chars_strict`) during `make dt_binding_check` that was not present in the original text binding.
--
--- Patch [1]: [PATCH] dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema ---
commit bda055e9092743c0cf88faae7d326b21581d09bb
Author: Bhargav Joshi <j.bhargav.u@gmail.com>
dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema
This commit converts the Texas Instruments Palmas USB Comparator binding from
the legacy text format to a modern DT schema.
> diff --git a/Documentation/devicetree/bindings/extcon/ti,extcon-palmas.yaml b/Documentation/devicetree/bindings/extcon/ti,extcon-palmas.yaml
> new file mode 100644
> index 0000000000000..0bcd8df79414a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/ti,extcon-palmas.yaml
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + palmas_usb {
[Severity: Low]
Is the underscore in this node name intentional?
The original text binding used a hyphen (palmas-usb). Using an underscore
violates standard device tree naming conventions and will trigger a dtc
node_name_chars_strict warning during make dt_binding_check.
Would it be better to stick with the original palmas-usb or use a generic
node name like usb-comparator?
> + compatible = "ti,palmas-usb-vid";
> + ti,wakeup;
> + ti,enable-id-detection;
> + ti,enable-vbus-detection;
> + id-gpios = <&palmas_gpio 0 GPIO_ACTIVE_HIGH>;
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-ti-extcon-palmas-v1-1-cd4071f0b9d9@gmail.com?part=1
next prev parent reply other threads:[~2026-07-20 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 20:21 [PATCH] dt-bindings: extcon: ti,extcon-palmas: Convert to DT schema Bhargav Joshi
2026-07-20 20:33 ` sashiko-bot [this message]
2026-07-21 14:07 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720203311.145671F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.bhargav.u@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox