From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD6E42DA4F for ; Tue, 21 Jul 2026 06:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784616901; cv=none; b=JWWBl2ZpMcOxecaA3H4ZihUQQh1HZB7I5uzJYJwtMf+yYfX2GTB8NqMRdkbFWWO8wQ1Cp+FT4dgJMlne9nNbG9mATGp9PUTowmC0Ye3/RP0miXZOe4XW/4zC/WsEgnXT4VYRzwXsrK5Raj7NEv1hCd14kejANt8+m7uzKKiWBcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784616901; c=relaxed/simple; bh=a0af6mRfXl6o/3aQ3C/YjqVxExTXT9xiwTDCu1uF7Ko=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ygl5g29DETdK4VShLTecHjHYQcfS54MJsfr2XVZ8j/PovMo8b7whGLhvbVkBW1lStPh7n+8Ynu0TM9Q866aiqzKvCV9q4cUOwGraBKCaZzjyywZVTtzklfOMYTSaGJeFDvUBUvnHVVQCEzWHF0XjY13BBQ9xDsX0Y+Rz5I1DeJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=NBBDrs/N; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NBBDrs/N" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ccf2360620so68977895ad.3 for ; Mon, 20 Jul 2026 23:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784616900; x=1785221700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qjG3+Srh1l1zMMK/k1OHJ2IZC5GaA1LItCzYqUBfaa0=; b=NBBDrs/NQavuacQelDdLBiYhlVe/vnCZtgSgZCweoqnblw2zw7vtbbK2kKVoJSCKmP Z9tnIvvap6QILEODnDzwAflKSsM3V0/Gk1ouNOJzHtWuWfT1cYPe/wPHsGrI2s7dpduP dJpZKdntutIwQsKg/AtNR+2au+rGVOJtv1lJM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784616900; x=1785221700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qjG3+Srh1l1zMMK/k1OHJ2IZC5GaA1LItCzYqUBfaa0=; b=WIiAUQF0BK5E10McgxxgC68/oigCudpn6qvbQFsqKYdo1Sj5nm5GBMo3fZ4ww4nez5 JH6WcESSNstNet4ATHqvLXITV9TEsBznWhxwM6DKORTXbKaoTE7/8IfVyTzYg308innt /UszK8OxcVhC2Au2Ytol0cDQJAwIM/eUo2ZgRG79A4z+w43BsJWVZ1dmcCW2Wxhi65TE ht0y0lDpWcemblgmKHKnF0yOUiQVt7K95bE5wSBlhRE2e/y5zlfXzUW35d1EuziUZLZB oq7ApjvJeBnI71LPkTrCNdt5hw+iV9EEIr3/ITEJa08w2FPU57+VG8tQQlJNwS9sVQIR Gzzg== X-Forwarded-Encrypted: i=1; AHgh+RrzehLx8W4z/gi1dJvsognSCkKRBdY8lJXzQ+5co3Q0NfFW5lzts3DneGoV831vj/LT07AVlAhEbUR5@vger.kernel.org X-Gm-Message-State: AOJu0Yx2kGOZOygGDK0eZncbYnn6gOo0xso9F83jTl7/xzihM/1sz9NV pZZ/Kcix7eBmf4BvWtR8H/7EaD41IUjS9EJ/h3m2UyQpbPPBSsQ8yWO/eyu/4USR7g== X-Gm-Gg: AfdE7clYEgz1Yqh9R0xZHqlSJpL/PIAIAy+qixirya3wi6Esg42YGj2uvcOYtBXGdvt ahuaQA2Cbtl0NMM82EdQm6p9fZqABGFrtf5ZCWcchTplEPVtItuK3P012LDESlGotCVcxRhJgo4 1D2pOhlN9L+3KaIY/jsLEqLsVh6IOPOZrCUVmhk6jWkkHLahI3OJxaXg9SEe2PKeEH3RyFUW3yL Y2fmxFWPgqaBRUjxrXGNAn1iv6PIxgKPpVQmL1tkr3KvIqRiMOUJJOkvDArGITWlsQvOXA6N8R7 /yui6brhlge63lEZNylaAJcTInvLiEeEQzEGt+1IdM7UR6ozbOyTwTJiIbmkCtC4iB2lNJ3UJ0w TXzTUfUL+IpLWuT+l7twwRNV0XTirRla8onH/cOBPDMowWY93f0L3kyALUepneffmj6NvQicwFo IZnfzaAv5HJ98ziyFiFcTadRYX7PdzMbEHV7JjHqWbx3tDbtYqQmq+STn5oPk= X-Received: by 2002:a17:903:1a90:b0:2cc:6b7a:dfcb with SMTP id d9443c01a7336-2cf349cc789mr186191295ad.33.1784616899938; Mon, 20 Jul 2026 23:54:59 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:3916:f048:32c3:931f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3448ee77sm69716005ad.4.2026.07.20.23.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 23:54:59 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v6 05/16] usb: hub: Return actual error from hub_configure() in hub_probe() Date: Tue, 21 Jul 2026 14:54:00 +0800 Message-ID: <20260721065413.2306137-6-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260721065413.2306137-1-wenst@chromium.org> References: <20260721065413.2306137-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The addition of power sequencing descriptor handling in the USB hub code requires dealing with deferred probing from pwrseq_get(). The power sequencing provider may not yet be available when the USB hub probes. Return the actual error code from hub_configure() when it fails, so that the driver core can notice the deferred probe request. Also rewrite this section into the standard error handling pattern: if (error) { # handle error return error; } # do more work return 0; Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - Rewrite into standard error handling pattern Changes since v1: - Moved "int ret" declaration in hub_configure() over here from the next patch --- drivers/usb/core/hub.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 715f26f05a31..8f8624a0d36a 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1875,6 +1875,7 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) struct usb_host_interface *desc; struct usb_device *hdev; struct usb_hub *hub; + int ret; desc = intf->cur_altsetting; hdev = interface_to_usbdev(intf); @@ -2006,14 +2007,15 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) usb_set_interface(hdev, 0, 0); } - if (hub_configure(hub, &desc->endpoint[0].desc) >= 0) { - onboard_dev_create_pdevs(hdev, &hub->onboard_devs); - - return 0; + ret = hub_configure(hub, &desc->endpoint[0].desc); + if (ret < 0) { + hub_disconnect(intf); + return ret; } - hub_disconnect(intf); - return -ENODEV; + onboard_dev_create_pdevs(hdev, &hub->onboard_devs); + + return 0; } static int -- 2.55.0.229.g6434b31f56-goog