Re: [PATCH v4 3/4] arm64: dts: rockchip: add HDMI RX audio on RK3588

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the DAPM widget for the HDMI RX capture source is incorrectly defined as an OUTPUT widget, breaking the DAPM graph for the capture path.
--

--- Patch [3]: [PATCH v4 3/4] arm64: dts: rockchip: add HDMI RX audio on RK3588 ---
commit e5a9a8ba89a4a45c730c1b44e28e899087346b1f
Author: Igor Paunovic <royalnet026@gmail.com>

arm64: dts: rockchip: add HDMI RX audio on RK3588

This commit exposes the HDMI RX controller's digital audio interfaces by
adding the #sound-dai-cells property. It also adds a shared
simple-audio-card routing the receiver I2S DAI to i2s7_8ch, mirroring
existing HDMI TX sound cards.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> index a2640014ee042..e0dce15643997 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi

[ ... ]

> @@ -23,6 +23,23 @@ simple-audio-card,cpu {
>  		};
>  	};
>  
> +	hdmi_receiver_sound: hdmi-receiver-sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,name = "RK3588 HDMI-IN";
> +		simple-audio-card,bitclock-master = <&hdmiin_codec>;
> +		simple-audio-card,frame-master = <&hdmiin_codec>;
> +		status = "disabled";
> +
> +		hdmiin_codec: simple-audio-card,codec {
> +			sound-dai = <&hdmi_receiver 0>;
> +		};

[Severity: High]
This isn't a bug introduced by this patch, but will this HDMI RX capture
path work correctly with DAPM given how the underlying codec is currently
defined?

Looking at the hdmi-codec driver used for this receiver:

sound/soc/codecs/hdmi-codec.c:hdmi_widgets[] {
    ...
    SND_SOC_DAPM_OUTPUT("RX"),
    ...
}

The DAPM widget for the HDMI RX capture source is incorrectly defined as an
OUTPUT (sink) instead of an INPUT (source).

When a capture stream starts, DAPM walks backward from the active CPU DAI
sink to find a source, but terminates at "RX" without finding an EP_SOURCE.
Does this prevent DAPM-managed components on the capture path (such as SoC
FIFOs, regulators, or clock supplies) from powering on, causing silent
failures during capture?

> +
> +		simple-audio-card,cpu {
> +			sound-dai = <&i2s7_8ch>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721064115.64809-1-royalnet026@gmail.com?part=3