Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 09/10] ARM: tegra: tf701t: Configure UART-B line used for GPS
Date: Tue, 21 Jul 2026 10:23:40 +0000	[thread overview]
Message-ID: <20260721102340.C976D1F01559@smtp.kernel.org> (raw)
In-Reply-To: <20260721101059.451699-10-clamor95@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undocumented compatible string `nvidia,tegra114-hsuart`.
--

--- Patch [9]: [PATCH v2 09/10] ARM: tegra: tf701t: Configure UART-B line used for GPS ---
commit de78632e3f3da744e644c7f7a6023ab3e302145b
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: tf701t: Configure UART-B line used for GPS

This commit configures the UART-B line on the Tegra114 Asus TF701T device
to use the high-speed UART (hsuart) driver. This change is necessary
because the GPS device is linked to this specific serial port.

> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> index 32d55c18c7446..0d182fa5c1af2 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> @@ -1283,6 +1283,11 @@ drive-gma {
>  	};
>  
>  	serial@70006040 {
> +		compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart";

[Severity: Low]
Is it expected for "nvidia,tegra114-hsuart" to be undocumented in the
device tree bindings?

Using this compatible string here will trigger a dtbs_check warning during
build validation since it is missing from the YAML binding located at
Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.yaml.

> +		reset-names = "serial";
> +		/delete-property/ reg-shift;
> +		status = "okay";
> +
>  		/* GPS */
>  	};
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721101059.451699-1-clamor95@gmail.com?part=9

  reply	other threads:[~2026-07-21 10:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 10:10 [PATCH v2 00/10] ARM: tegra: tf701t: Add new features Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 01/10] ARM: tegra: tf701t: Configure CPU DFLL clock node Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 02/10] ARM: tegra: tf701t: Add core-supply to PMC node Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 03/10] ARM: tegra: tf701t: Add MC and EMC timing nodes Svyatoslav Ryhel
2026-07-21 10:31   ` sashiko-bot
2026-07-21 10:10 ` [PATCH v2 04/10] ARM: tegra: tf701t: Remove pin_ prefix from PMIC pinmux Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 05/10] ARM: tegra: tf701t: Add thermal zones for nct1008 sensor Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 06/10] ARM: tegra: tf701t: Tune MMC devices Svyatoslav Ryhel
2026-07-21 10:33   ` sashiko-bot
2026-07-21 10:10 ` [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 08/10] ARM: tegra: tf701t: Complete power sensor node Svyatoslav Ryhel
2026-07-21 10:10 ` [PATCH v2 09/10] ARM: tegra: tf701t: Configure UART-B line used for GPS Svyatoslav Ryhel
2026-07-21 10:23   ` sashiko-bot [this message]
2026-07-21 10:10 ` [PATCH v2 10/10] ARM: tegra: tf701t: Add chosen node Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721102340.C976D1F01559@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox