Re: [PATCH v29 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `secure-enclave` node is missing the required `memory-region` property, violating the DT binding and causing the `se_ctrl` driver to fail probe unconditionally with `-ENODEV`.
--

--- Patch [6]: [PATCH v29 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 2de8edbeb186b1bf74b55f8e1113a94023d98cce
Author: Pankaj Gupta <pankaj.gupta@nxp.com>
arm64: dts: imx8ulp: add secure enclave node

This commit adds support for the NXP EdgeLock Enclave firmware (se-fw)
on imx8ulp-evk by defining the secure-enclave node in the device tree.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index c6d1bb9edf388..182f1444b6434 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,13 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +		};

[Severity: High]
Does this node need a memory-region property?

Looking at the driver side in drivers/firmware/imx/se_ctrl.c, when the
hardware matches and sets reserved_dma_ranges = true, se_if_probe() executes
this logic:

drivers/firmware/imx/se_ctrl.c:se_if_probe() {
    ...
    if (if_node->reserved_dma_ranges) {
        ret = of_reserved_mem_device_init(dev);
        if (ret)
            return dev_err_probe(dev, ret,
                        "Failed to init reserved memory region.");
    }
    ...
}

Since the memory-region property is missing from the device tree node here,
will of_reserved_mem_device_init() fail to parse the phandle and return
-ENODEV, causing the probe to unconditionally fail?

>  	};
>  
>  	cm33: remoteproc-cm33 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-imx-se-if-v29-0-04a362f4fcca@nxp.com?part=6