Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Eduard Bostina" <egbostina@gmail.com>
Cc: devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
	dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
	robh@kernel.org, linux-input@vger.kernel.org,
	conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH v3 2/4] ARM: dts: Rename the TPS65217 regulator nodes
Date: Tue, 21 Jul 2026 11:26:36 +0000	[thread overview]
Message-ID: <20260721112636.773E01F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260721112133.70382-3-egbostina@gmail.com>

> The TPS65217 regulator nodes are named regulator@0 to regulator@6 and
> rely on the deprecated 'regulator-compatible' property to be matched
> against the driver, which looks for "dcdc1" to "ldo4".
> 
> Documentation/devicetree/bindings/regulator/tps65217.txt states the
> regulators must be named dcdc[1-3] and ldo[1-4].
> 
> Rename the nodes accordingly and drop 'regulator-compatible' along with
> the unit addresses it made necessary.
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721112133.70382-1-egbostina@gmail.com?part=2


  reply	other threads:[~2026-07-21 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 11:21 [PATCH v3 0/4] dt-bindings: Convert TI TPS65217 to DT schema Eduard Bostina
2026-07-21 11:21 ` [PATCH v3 1/4] ARM: dts: ti: am335x-guardian: Drop unused isink-en property Eduard Bostina
2026-07-21 11:24   ` sashiko-bot
2026-07-21 11:21 ` [PATCH v3 2/4] ARM: dts: Rename the TPS65217 regulator nodes Eduard Bostina
2026-07-21 11:26   ` sashiko-bot [this message]
2026-07-21 11:21 ` [PATCH v3 3/4] dt-bindings: input: Convert TI TPS65217 power button to DT schema Eduard Bostina
2026-07-21 11:34   ` sashiko-bot
2026-07-21 15:02     ` Rob Herring
2026-07-21 11:21 ` [PATCH v3 4/4] dt-bindings: leds: backlight: Convert TPS65217 " Eduard Bostina
2026-07-21 11:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721112636.773E01F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=egbostina@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox