From: sashiko-bot@kernel.org
To: "David Heidelberg" <david@ixit.cz>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras
Date: Tue, 21 Jul 2026 12:45:20 +0000 [thread overview]
Message-ID: <20260721124521.D90621F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260721-pixel3-camera-v7-1-82d323c6c5d2@ixit.cz>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatched Pinctrl Sleep State: `&cci0_sleep` overridden instead of `&cci1_sleep`
--
--- Patch [1]: [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras ---
commit 6f3cf4398dc835a329292905a7fe098ccc06dc9c
Author: David Heidelberg <david@ixit.cz>
arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras
This patch adds support for the dual front IMX355 cameras on the Pixel 3.
The cameras are connected via CSIPHY ports 1 and 2, and are controlled over
the CCI I2C1 bus.
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> index 9368fd6b87515..c8a28133fb38d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
[ ... ]
> +&cci0_sleep {
> + /* bus has external pull-up */
> + /delete-property/ bias-pull-down;
> + bias-disable;
> +};
[Severity: Medium]
Is it intentional to modify the sleep state for &cci0_sleep here?
The new front cameras are added to the &cci_i2c1 bus below, which depends on
&cci1_sleep for its suspend state. Modifying &cci0_sleep means &cci1_sleep
will retain its default bias-pull-down configuration.
During suspend, the SoC will actively pull down the &cci_i2c1 pins, which
will fight the external pull-up resistors on that bus and cause continuous
leakage current and battery drain.
Should this remove the bias-pull-down property on &cci1_sleep instead?
> +
> &cci {
> status = "okay";
> };
> @@ -358,7 +444,63 @@ &cci {
> &cci_i2c1 {
> /* actuator @0c */
>
> - /* front camera, imx355 @1a */
> + front_cam: camera@10 {
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-pixel3-camera-v7-0-82d323c6c5d2@ixit.cz?part=1
next prev parent reply other threads:[~2026-07-21 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 12:33 [PATCH v7 0/2] Add initial dual front camera and rear flash support for Pixel 3 / 3 XL David Heidelberg via B4 Relay
2026-07-21 12:33 ` [PATCH v7 1/2] arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras David Heidelberg via B4 Relay
2026-07-21 12:36 ` Konrad Dybcio
2026-07-21 12:45 ` sashiko-bot [this message]
2026-07-21 12:33 ` [PATCH v7 2/2] arm64: dts: qcom: sdm845-google: Enable PMI8998 camera flash LEDs David Heidelberg via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721124521.D90621F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox