From: sashiko-bot@kernel.org
To: "Fabio Estevam" <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property
Date: Tue, 21 Jul 2026 13:40:50 +0000 [thread overview]
Message-ID: <20260721134052.44F451F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260721133408.44240-1-festevam@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch incorrectly removes the 'ti,rt-thr' property instead of correcting it to 'ti,max-rt', permanently discarding the board designer's intended touchscreen resistance threshold.
--
--- Patch [1]: [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property ---
commit f09729b87ec6a8e1dd741bb9d8987b1590909b19
Author: Fabio Estevam <festevam@gmail.com>
arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property
This commit removes the ti,rt-thr property from the rk3566-bigtreetech-cb2
device tree because it is undocumented.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> index b6cf03a7ba66b..542269c338daf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> @@ -569,7 +569,6 @@ tft_tp: touchscreen@48 {
> reg = <0x48>;
> status = "okay";
> ti,x-plate-ohms = <660>;
> - ti,rt-thr = <3000>;
[Severity: Medium]
Should this property be corrected to ti,max-rt rather than being removed?
While ti,rt-thr is indeed invalid and ignored (falling back to the default
max resistance of 4095), deleting it entirely discards the board designer's
intended touchscreen resistance threshold (3000) instead of fixing the typo.
The tsc2007 driver documents ti,max-rt for this purpose, which would
preserve the configuration intent.
> ti,fuzzx = <32>;
> ti,fuzzy = <16>;
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721133408.44240-1-festevam@gmail.com?part=1
prev parent reply other threads:[~2026-07-21 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 13:34 [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property Fabio Estevam
2026-07-21 13:40 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721134052.44F451F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox