Re: [PATCH v5 1/2] dt-bindings: media: i2c: Add mira220 image sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema uses `additionalProperties: false` at the top level alongside an `$ref` to `video-interface-devices.yaml` in an `allOf` block, which incorrectly rejects inherited standard properties.
--

--- Patch [1]: [PATCH v5 1/2] dt-bindings: media: i2c: Add mira220 image sensor ---
commit 4fdfbcc612e9cd0371486dfa12391a33292c795a
Author: Philippe Baetens <philippebaetens@gmail.com>

dt-bindings: media: i2c: Add mira220 image sensor

This commit adds device tree bindings for the AMSOSRAM Mira220 2.2 MP NIR
enhanced global shutter image sensor. It defines the required properties,
supplies, and video output port configuration for the device.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> new file mode 100644
> index 0000000000000..294211da8f2a1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> @@ -0,0 +1,101 @@
[ ... ]
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdig-supply
> +  - vana-supply
> +  - vddl-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Medium]
Since the schema includes a reference to video-interface-devices.yaml in the
allOf block, should this be unevaluatedProperties: false instead?

Using additionalProperties: false at the top level only checks the properties
defined locally in the current schema block. It ignores everything included via
the allOf reference, which means valid device tree properties inherited from
the standard video-interface-devices.yaml schema (such as rotation or
orientation) will fail dt_binding_check validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-mira220-v5-0-533b0ad1065e@ideasonboard.com?part=1