Re: [PATCH v6 2/3] dt-bindings: display: sn65dsi83: Add output data-lanes property

[Rob Herring <robh@kernel.org>]

On Tue, Jul 21, 2026 at 07:20:21AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Redefining `endpoint` in `port@2` and `port@3` with `unevaluatedProperties: false` unconditionally rejects valid vendor-specific properties (`ti,lvds-*`), breaking schema validation.
> --
> 
> --- Patch [2]: [PATCH v6 2/3] dt-bindings: display: sn65dsi83: Add output data-lanes property ---
> commit c8014187b83b236fe065488764ddd649223ae575
> Author: Wojciech Dubowik <Wojciech.Dubowik@mt.com>
> dt-bindings: display: sn65dsi83: Add output data-lanes property
> 
> Adds an optional output lvds data lanes property with two allowed values
> for standard and reversed layouts, informing the driver if the reverse
> lvds config option needs to be set.
> 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > index e69b6343a8ebb..4000bf0b13709 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> > @@ -86,10 +86,54 @@ properties:
> >          description: Video port for LVDS Channel-A output (panel or bridge).
> >          $ref: '#/$defs/lvds-port'
> >  
> > +        properties:
> > +          endpoint:
> > +            $ref: /schemas/media/video-interfaces.yaml#
> > +            unevaluatedProperties: false
> 
> [Severity: Medium]
> Does this local redefinition of endpoint with unevaluatedProperties: false 
> unconditionally reject valid vendor-specific properties (like ti,lvds-*) 
> and break schema validation? 
> 
> In JSON Schema, unevaluatedProperties only considers properties evaluated 
> within its own local evaluation path, so it won't see properties evaluated 
> by the parallel $ref: '#/$defs/lvds-port'.

sashiko is right here.

Rob