Re: [PATCH v4] arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Sharing the same reset GPIO across multiple cs35l43 codec nodes using `GPIO_OPEN_DRAIN` does not prevent `-EBUSY` probe failures.
- [Medium] The commit message claims to 'Remove output-low/output-high from TLMM pinctrl', but `output-high` is still present in the `i2s1_default` pin configuration.
--

--- Patch [1]: [PATCH v4] arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng) ---
commit 409a566ed91cfcb1ea5b448084073b5d36eb09ec
Author: map220v <map220v300@gmail.com>

arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng)
    
Add device tree for Xiaomi Pad 6S Pro (sheng) based on SM8550.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts b/arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts
> new file mode 100644
> index 0000000000000..a5aa49a01dde9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8550-xiaomi-sheng.dts

[ ... ]

> +&i2c5 {
> +	clock-frequency = <1000000>;
> +	status = "okay";
> +
> +	cs35l43_trl: cs35l43@40 {
> +		compatible = "cirrus,cs35l43";
> +		reg = <0x40>;
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <98 IRQ_TYPE_LEVEL_LOW>;
> +		reset-gpios = <&tlmm 90 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;

[Severity: High]
The commit message mentions adding GPIO_OPEN_DRAIN to avoid -EBUSY on
shared reset-gpios. Does this actually prevent the probe failures?

When devm_gpiod_get_optional() is called by the codec driver without
GPIOD_FLAGS_BIT_NONEXCLUSIVE in the driver's C code, gpiolib enforces 
exclusive access.

Since GPIO_OPEN_DRAIN only configures the hardware output behavior, it looks
like the first cs35l43 codec instance will succeed but the subsequent
instances will still fail to probe with -EBUSY.

[ ... ]

> +	i2s1_default: i2s1-default-state {
> +		sck-pins {
> +			pins = "gpio121";
> +			function = "i2s1_sck";
> +			drive-strength = <8>;
> +			bias-disable;
> +			output-high;
> +		};

[Severity: Medium]
The commit message states "Remove output-low/output-high from TLMM pinctrl",
but output-high is still present in this i2s1_default pin configuration. Did
this get missed during the cleanup?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721145452.1996-1-code_0002@163.com?part=1