Re: [PATCH 2/2] dt-bindings: sound: remove google,storm-audio binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete cleanup leaves the IPQ806x LPASS driver as unreachable dead code.
--

--- Patch [2]: [PATCH 2/2] dt-bindings: sound: remove google,storm-audio binding ---
commit 4f1f4fbba8c2f852f688a4151731bed0fe4a61f1
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

dt-bindings: sound: remove google,storm-audio binding

This commit removes the device tree binding for the "google,storm-audio"
sound complex. The removal is done because the accompanying ipq806x Storm
machine driver is no longer present.

> With the ipq806x Storm machine driver gone, the accompanying device tree
> binding describing the "google,storm-audio" sound complex is no longer
> used by any driver or device tree. Remove it.

[Severity: Medium]
Since the ipq806x Storm machine driver is gone, does this leave the
IPQ806x LPASS driver as unreachable dead code?

Looking at sound/soc/qcom/Kconfig, SND_SOC_LPASS_IPQ806X is a hidden
Kconfig symbol:

config SND_SOC_LPASS_IPQ806X
	tristate
	select SND_SOC_LPASS_CPU
	select SND_SOC_LPASS_PLATFORM

If the machine driver was the only config that selected it, this symbol can
no longer be enabled. This would mean the compilation target in
sound/soc/qcom/Makefile can no longer be reached:

obj-$(CONFIG_SND_SOC_LPASS_IPQ806X) += snd-soc-lpass-ipq806x.o

Should this incomplete cleanup be addressed by removing the orphaned config
and driver file as well?

> diff --git a/Documentation/devicetree/bindings/sound/storm.txt b/Documentation/devicetree/bindings/sound/storm.txt
> deleted file mode 100644
> index 062a4c185fa9d..0000000000000
> --- a/Documentation/devicetree/bindings/sound/storm.txt
> +++ /dev/null
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-drop-sound-storm-v1-0-23ae4a689ffe@oss.qualcomm.com?part=2