Re: [PATCH 1/2] dt-bindings: iio: dac: add support for mcp47a1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding incorrectly requires `vref-supply`, but the MCP47A1 likely does not have a dedicated VREF pin.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: iio: dac: add support for mcp47a1 ---
commit d1dc3c2e573f4f52e69aabeb608ccb23acd5a123
Author: Joshua Crofts <joshua.crofts1@gmail.com>

dt-bindings: iio: dac: add support for mcp47a1

This commit introduces the device tree bindings and MAINTAINERS entry for
the Microchip MCP47A1, a 6-bit volatile digital-to-analog converter.

> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml
> new file mode 100644
> index 0000000000000..3322fca03b3a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - vref-supply

[Severity: Medium]
Does the MCP47A1 actually have a dedicated VREF pin? Standard Microchip I2C
DACs in this class (such as the 6-pin MCP4725) typically use VDD as their
voltage reference.

If there is no physical VREF pin on this hardware, requiring vref-supply
here forces device tree authors to define dummy regulators in their
device trees just to pass schema validation.

> +  - vdd-supply
> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-mcp47a1-add-support-v1-0-da045a2567e3@gmail.com?part=1