Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX16545/MAX16550 and Volterra VT7505

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]

On Wed, Jul 22, 2026 at 03:03:37PM +0000, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@juniper.net>
> 
> Add device tree binding documentation for the Analog Devices MAX16545 and
> MAX16550, and the Volterra VT7505 PMBus controllers.
> 
> Signed-off-by: Sanman Pradhan <psanman@juniper.net>
> ---
>  .../bindings/hwmon/pmbus/adi,vt7505.yaml      | 83 +++++++++++++++++++
>  1 file changed, 83 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,vt7505.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,vt7505.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,vt7505.yaml
> new file mode 100644
> index 000000000000..286c88eb7be8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,vt7505.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/adi,vt7505.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX16545/MAX16550 and Volterra VT7505 PMBus controllers
> +
> +maintainers:
> +  - Sanman Pradhan <psanman@juniper.net>
> +
> +description: |
> +  The Analog Devices MAX16545 and MAX16550, and the Volterra VT7505, are PMBus
> +  controllers that provide input/output voltage, input/output current,
> +  input power and temperature monitoring over the PMBus interface.
> +
> +  The MAX16545 uses the same programming model as the VT7505.
> +
> +  Datasheets:
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/max16545b-max16545c.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/max16550.pdf
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - adi,max16550
> +          - adi,vt7505
> +      - items:
> +          - const: adi,max16545
> +          - const: adi,vt7505
> +
> +  reg:
> +    maxItems: 1
> +
> +  adi,rload-ohms:
> +    description:
> +      Resistance in ohms of the external current-report resistor connected
> +      between the ILOAD pin and ground. It is used to scale the reported
> +      input and output current and power.:wq
> +    minimum: 1
> +    default: 4750
> +
> +  adi,ocp-severe-filter:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Deglitch time applied to the severe overcurrent-protection comparator,
> +      programmed into the MFR_CONFIG[15:14] field. The MAX16550 and VT7505
> +      expose this field; it decodes as 0 = 0 us, 1 = 1 us, 2 = 2 us and
> +      3 = 10 us. On the MAX16545 the severe overcurrent delay is fixed and

Please represent this property in microseconds.
pw-bot: changes-requested

Otherwise, I think this looks fine.

Thanks,
Conor.

> +      these bits are reserved.
> +    enum: [0, 1, 2, 3]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]