Re: [PATCH 3/3] riscv: dts: spacemit: k3: add i2s0-i2s5 nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree uses the undeclared macro `CLK_MPMU_I2S_SYSCLK`, which will cause a fatal syntax error during DT compilation.
--

--- Patch [3]: [PATCH 3/3] riscv: dts: spacemit: k3: add i2s0-i2s5 nodes ---
commit 89d824064dd5e05a6a01752a3478d73808fc8c1f
Author: Troy Mitchell <troy.mitchell@linux.spacemit.com>

riscv: dts: spacemit: k3: add i2s0-i2s5 nodes

This commit adds the six SSPA-based I2S controller nodes for the K3 SoC,
configuring their clocks, DMAs, and resets.

> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index 19fc9b49668ed..967e5d87527a1 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> @@ -1081,6 +1081,125 @@ uart10: serial@d401f000 {
>  			status = "disabled";
>  		};
>  
> +		i2s0: i2s@d4026000 {
> +			compatible = "spacemit,k3-i2s";
> +			reg = <0x0 0xd4026000 0x0 0x30>;
> +			clocks = <&syscon_mpmu CLK_MPMU_I2S0_SYSCLK>,
> +				 <&syscon_apbc CLK_APBC_I2S0_BCLK>,
> +				 <&syscon_apbc CLK_APBC_I2S0_BUS>,
> +				 <&syscon_apbc CLK_APBC_I2S0>,
> +				 <&syscon_mpmu CLK_MPMU_I2S0_SYSCLK_DIV>,
> +				 <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,

[Severity: Low]
Is CLK_MPMU_I2S_SYSCLK defined anywhere?

It appears this macro is undeclared, which will cause a fatal syntax error
during device tree compilation.

This same undeclared macro is also used in the i2s1 through i2s5 nodes added
by this patch.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-kx-i2s-dts-v1-0-d22cb6cfaab5@linux.spacemit.com?part=3