Re: [PATCH v10 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding schema for `qcom,glymur-tcsr` acts as a clock and reset provider but omits `#clock-cells` and `#reset-cells` from its `required` properties list, violating subsystem guidelines.
--

--- Patch [1]: [PATCH v10 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding ---
commit 9dc2aeb415b01bb3192fd7c7579819d2fd9111f4
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move glymur TCSR to own binding

The QREF block supplies reference clocks to PCIe PHYs and requires
dedicated LDO supplies to operate. This commit adds a dedicated binding
file for qcom,glymur-tcsr to document the supply properties.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml

[ ... ]

> +        - vdda-refgen3-0p9-supply
> +        - vdda-refgen3-1p2-supply
> +        - vdda-refgen4-0p9-supply
> +        - vdda-refgen4-1p2-supply
> +
> +required:
> +  - compatible
> +  - clocks

[Severity: Medium]
Since qcom,glymur-tcsr acts as a clock and reset provider, should
#clock-cells and #reset-cells be added to this required list to ensure
schema validation enforces these capabilities?

While this same omission might exist in the shared qcom,sm8550-tcsr.yaml
binding from which this was likely copied, it appears to be introduced
anew in this dedicated file.

> +
> +additionalProperties: false
> +
> +examples:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-tcsr_qre_0721-v10-0-d2fa68c63b78@oss.qualcomm.com?part=1