From: sashiko-bot@kernel.org
To: "Mattijs Korpershoek" <mkorpershoek@kernel.org>
Cc: devicetree@vger.kernel.org, neil.armstrong@linaro.org,
vkoul@kernel.org, olteanv@gmail.com,
linux-phy@lists.infradead.org, robh@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY
Date: Wed, 22 Jul 2026 13:54:00 +0000 [thread overview]
Message-ID: <20260722135401.132D01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260722-phy-qcom-qmp-usb-8255-v3-1-e789070b48f7@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema uses `unevaluatedProperties: false` without referencing any external schema via `$ref`.
--
--- Patch [1]: [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY ---
commit 7b3aaeb1e0d8c8cd82e7d6b2d97dc88cb763da87
Author: Mattijs Korpershoek <mkorpershoek@kernel.org>
Date: Wed Jul 22 13:45:44 2026 +0000
dt-bindings: phy: Add sa8255p USB PHY
This commit introduces a new devicetree binding for the Qualcomm QMP Super
Speed (SS) UNI PHY on the SA8255P platform. The hardware abstracts resources
like clocks and interconnects through firmware via the SCMI power protocol.
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8255p-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8255p-qmp-usb3-uni-phy.yaml
> new file mode 100644
> index 0000000000000..d274d500fc9c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8255p-qmp-usb3-uni-phy.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - "#phy-cells"
> + - power-domains
> + - power-domain-names
> +
> +unevaluatedProperties: false
[Severity: Low]
Since this schema does not reference any external schemas via $ref, should
this be additionalProperties: false instead of unevaluatedProperties: false?
> +
> +examples:
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-phy-qcom-qmp-usb-8255-v3-0-e789070b48f7@kernel.org?part=1
next prev parent reply other threads:[~2026-07-22 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 13:45 [PATCH v3 0/2] Add support for SA8255P in the qcom-qmp-usb phy driver Mattijs Korpershoek
2026-07-22 13:45 ` [PATCH v3 1/2] dt-bindings: phy: Add sa8255p USB PHY Mattijs Korpershoek
2026-07-22 13:54 ` sashiko-bot [this message]
2026-07-22 13:45 ` [PATCH v3 2/2] phy: qcom: qmp-usb: Add support for SA8255P Mattijs Korpershoek
2026-07-22 14:01 ` sashiko-bot
2026-07-22 14:32 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722135401.132D01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mkorpershoek@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox