Re: [PATCH v9 07/17] iio: test: add kunit tests for channel prefix naming generation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `iio-test-channel-prefix` KUnit test module is missing a `MODULE_LICENSE()` declaration, which will cause it to taint the kernel and fail to load when compiled as a loadable module.
--

--- Patch [7]: [PATCH v9 07/17] iio: test: add kunit tests for channel prefix naming generation ---
commit cea50e2c0ecc39138633c2f38aadeebe93da4611
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: test: add kunit tests for channel prefix naming generation

This commit adds a KUnit test suite for the __iio_chan_prefix_emit() helper
function. It tests various iio_shared_by modes, differential and modified
channel configurations, and exercises known error paths.

> diff --git a/drivers/iio/test/iio-test-channel-prefix.c b/drivers/iio/test/iio-test-channel-prefix.c
> new file mode 100644
> index 0000000000000..d049e4222c40e
> --- /dev/null
> +++ b/drivers/iio/test/iio-test-channel-prefix.c
[ ... ]
> +static struct kunit_suite iio_channel_prefix_test_suite = {
> +	.name = "iio-channel-prefix",
> +	.test_cases = iio_chan_prefix_test_cases,
> +};
> +
> +kunit_test_suite(iio_channel_prefix_test_suite);
> +
> +MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");

[Severity: Medium]
Is a MODULE_LICENSE() declaration missing at the end of this file?

Because CONFIG_IIO_CHANNEL_PREFIX_KUNIT_TEST is defined as a tristate in
the Kconfig, this test can be compiled as a loadable module. 

Without a MODULE_LICENSE() declaration, won't this taint the kernel and fail
to load due to unresolved GPL-exported symbols from the core KUnit framework
(such as __kunit_test_suites_init)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-ad9910-iio-driver-v9-0-459d1df5ac56@analog.com?part=7