Re: [PATCH V9 4/4] arm64: dts: rockchip: Add Anbernic RG Vita-Pro

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The SD card slot 1 (&sdmmc) keeps its I/O voltage (VQMMC) active while its core power (VMMC) is turned off during system suspend.
- [Medium] The DisplayPort alt-mode Vendor Defined Object (VDO) is configured with an invalid value of 0xffffffff.
--

--- Patch [4]: [PATCH V9 4/4] arm64: dts: rockchip: Add Anbernic RG Vita-Pro ---
commit 9b7e292cd22ab667469b2d0609662deb58a25790
Author: Chris Morgan <macromorgan@hotmail.com>

arm64: dts: rockchip: Add Anbernic RG Vita-Pro

Add device tree for the Anbernic RG Vita-Pro, based on the Rockchip
RK3576. All hardware is currently working except for the accelerometer,
the touchscreen, the battery monitor, and DisplayPort over USB-C. PWM
is also missing currently, and as a result the LEDs and panel backlight
are currently controlled via GPIO but will be changed to PWM once
supported.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts
> new file mode 100644
> index 0000000000000..344ba18705338
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-anbernic-rg-vita-pro.dts

[ ... ]

> +	vcc3v3_sd_s0: regulator-vcc3v3-sd-s0 {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
> +		pinctrl-0 = <&vcc_3v3_sd_s0_h>;
> +		pinctrl-names = "default";
> +		regulator-max-microvolt = <3300000>;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-name = "vcc3v3_sd_s0";
> +		regulator-state-mem {
> +			regulator-off-in-suspend;
> +		};
> +	};

[ ... ]

> +			vccio_sd_s0: pldo-reg5 {
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-name = "vccio_sd_s0";
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +				};
> +			};

[Severity: Medium]
Will this configuration cause the SD card's internal I/O clamping diodes to
be forward-biased during system suspend?

Since vccio_sd_s0 (used as vqmmc-supply for the sdmmc node) remains active
with regulator-on-in-suspend, but vcc3v3_sd_s0 (used as vmmc-supply) is
powered off with regulator-off-in-suspend, this can back-power the SD card.

Over time this could lead to excess battery drain and hardware degradation
for both the SD card and the SoC's SD controller.

[ ... ]

> +			altmodes {
> +				displayport {
> +					svid = /bits/ 16 <0xff01>;
> +					vdo = <0xffffffff>;
> +				};
> +			};

[Severity: Medium]
Is 0xffffffff the intended Vendor Defined Object (VDO) value for the
DisplayPort alt-mode in husb311?

This value asserts undefined reserved bits and advertises mutually exclusive
capabilities (such as being both a DP plug and a receptacle simultaneously).
This violates the DisplayPort Alt Mode specification and could break
negotiation with compliant Type-C partners.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722165806.161020-1-macroalpha82@gmail.com?part=4