Re: [PATCH] dt-bindings: arm: omap: Convert L4 interconnect to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

New issues:
- [Medium] Top-level `additionalProperties: true` disables validation of mis-typed or undocumented properties.

Pre-existing issues:
- [Medium] The schema enum omits multiple actively used compatibles and carries over a typo from the text binding.
--

--- Patch [1]: [PATCH] dt-bindings: arm: omap: Convert L4 interconnect to DT schema ---
commit 1d2037651b45f654606d66d4cc1b50eca85740dc
Author: Eduard Bostina <egbostina@gmail.com>

dt-bindings: arm: omap: Convert L4 interconnect to DT schema

This commit converts the Texas Instruments OMAP L4 interconnect bus bindings
from text to YAML schema. It defines the compatible property as an array and
adds a select block to restrict the schema to TI-specific nodes.

> diff --git a/Documentation/devicetree/bindings/arm/omap/ti,omap-l4.yaml b/Documentation/devicetree/bindings/arm/omap/ti,omap-l4.yaml
> new file mode 100644
> index 0000000000000..465d48f44730a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/ti,omap-l4.yaml
[ ... ]
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - ti,omap2-l4
[ ... ]
> +          - ti,dra7-l4-wkup
> +          - ti,am3-l4-wkup
> +          - ti,am4-l4-wkup
> +  required:
> +    - compatible

[Severity: Medium]
This is a pre-existing issue carried over from the text binding, but the
schema enum omits multiple actively used compatibles like ti,am33xx-l4-fw,
ti,am4-l4-fast, and ti,dra7-l4-per1.

Does this also carry over a typo in the am33xx name, specifying ti,am3-l4-wkup
instead of ti,am33xx-l4-wkup?

Because the custom select block strictly filters on this enum, device tree
nodes using the missing compatibles will silently bypass this schema entirely
during validation.

[ ... ]
> +required:
> +  - compatible
> +  - ranges
> +
> +additionalProperties: true

[Severity: Medium]
Does setting additionalProperties to true defeat a primary benefit of the
schema conversion?

This globally disables strict property validation for the node. If a property
is misspelled (like reg-name instead of reg-names) or undocumented, the
schema will silently accept it.

Should this bus node instead use a $ref to simple-bus.yaml or
simple-pm-bus.yaml and set unevaluatedProperties to false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722171840.299303-1-egbostina@gmail.com?part=1