Re: [PATCH 2/2] riscv: dts: spacemit: k3-com260-ifx: add eeprom on i2c1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The unprogrammed carrier board EEPROM is incorrectly marked `read-only`, preventing it from being programmed.
--

--- Patch [2]: [PATCH 2/2] riscv: dts: spacemit: k3-com260-ifx: add eeprom on i2c1 ---
commit 94048b36205e1670d5a85578a1cb608f4a7a0439
Author: Jennifer Berringer <jberring@redhat.com>

riscv: dts: spacemit: k3-com260-ifx: add eeprom on i2c1

Enable i2c1 for the k3-com260-ifx board and attach a 24c02 EEPROM. The commit
message notes that this carrier board EEPROM comes unprogrammed from the
factory on some boards.

> diff --git a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> index e7f76cd24b903..a5c08a7a781a9 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts

[ ... ]

> @@ -20,6 +20,21 @@ chosen {
>  	};
>  };
>  
> +&i2c1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c1_1_cfg>;
> +	status = "okay";
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c02";
> +		pagesize = <8>;
> +		reg = <0x50>;
> +		read-only;

[Severity: Medium]
The commit message mentions that some boards do not have any data programmed
on this EEPROM from the factory. Does marking this eeprom@50 node as
read-only prevent users or provisioning scripts from writing the initial
configuration data to the EEPROM from Linux?

> +		size = <256>;
> +		status = "okay";
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722202848.1817988-1-jberring@redhat.com?part=2