Re: [RFC PATCH 7/8] dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The unit-address in the example node name `audio-codec@3,0` does not match its `reg` property `<0 3>`.
--

--- Patch [7]: [RFC PATCH 7/8] dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec ---
commit 5fe69f3b063a8e89646196eb389830ac9c6473c6
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec

This commit introduces the device tree binding for the Qualcomm WCD9378
SoundWire slave devices. It defines properties for both mobile mode and
SDCA compute mode configurations.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml
> new file mode 100644
> index 0000000000000..2ed4ad92958ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml

[ ... ]

> +  # SDCA / compute mode: single aggregated slave -- owns supplies,
> +  # reset GPIO and mic-bias voltages.
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    soundwire@7630000 {
> +        reg = <0x07630000 0x10000>;
> +        #address-cells = <2>;
> +        #size-cells = <0>;
> +
> +        wcd9378c_sdw: audio-codec@3,0 {
> +            compatible = "sdw20217011000";
> +            reg = <0 3>;

[Severity: Low]
Should the unit address in the node name be audio-codec@0,3 to properly match
the reg property <0 3>? 

The device tree compiler will likely emit a unit_address_vs_reg warning
during make dt_binding_check when parsing this example.

> +
> +            qcom,compute-mode;
> +            qcom,port-mapping = <2 2 3 4 5 6 7 8>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722234221.884765-1-srinivas.kandagatla@oss.qualcomm.com?part=7