From: sashiko-bot@kernel.org
To: "Aneesh Pradhan" <aneeshpradhan2004@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
Date: Thu, 23 Jul 2026 01:34:17 +0000 [thread overview]
Message-ID: <20260723013417.D5DFA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723012431.48499-4-aneeshpradhan@acm.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device Tree blob entries in the Makefile are not sorted alphabetically.
--
--- Patch [3]: [PATCH 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support ---
commit f1e9e7f386e094ca8238575174ce1d5dde0b3f6c
Author: Catherine Frederick (coolguy) <serenity@floorchan.org>
arm64: dts: qcom: add initial Motorola Moto E4 (perry) support
This commit adds MSM8917 and MSM8920 board files for the Motorola Moto E4
(perry) sharing a common dtsi. It includes an initial subset of peripherals
such as regulators, eMMC/SD, USB OTG, and touchscreen, while deferring
peripherals lacking mainline drivers.
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index e05414290d8e5..d92bd2863ef23 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -109,6 +109,8 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-riva.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-rolex.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-tiare.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8917-motorola-perry.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8920-motorola-perry.dtb
[Severity: Low]
This isn't a bug, but shouldn't these new device tree blobs be sorted
alphabetically within the Makefile?
It looks like msm8917-motorola-perry.dtb is being inserted after the
msm8917-xiaomi-* entries. Placing it before msm8917-xiaomi-riva.dtb would
follow the existing sorting convention and help minimize merge conflicts.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723012431.48499-1-aneeshpradhan@acm.org?part=3
next prev parent reply other threads:[~2026-07-23 1:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 1:24 [PATCH 0/2] clk: qcom: add MSM8920 RPM clock controller support Aneesh Pradhan
2026-07-23 1:24 ` [PATCH 1/2] dt-bindings: clock: qcom,rpmcc: add MSM8920 Aneesh Pradhan
2026-07-23 1:24 ` [PATCH 2/2] clk: qcom: smd-rpm: add MSM8920 support Aneesh Pradhan
2026-07-23 1:24 ` [PATCH 0/3] arm64: dts: qcom: initial MSM8920 and Motorola Moto E4 (perry) Aneesh Pradhan
2026-07-23 1:24 ` [PATCH 1/3] dt-bindings: arm: qcom: add " Aneesh Pradhan
2026-07-23 1:24 ` [PATCH 2/3] arm64: dts: qcom: add initial MSM8920 device tree Aneesh Pradhan
2026-07-23 1:24 ` [PATCH 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support Aneesh Pradhan
2026-07-23 1:34 ` sashiko-bot [this message]
2026-07-23 1:46 ` [PATCH v2 0/3] arm64: dts: qcom: initial MSM8920 and Motorola Moto E4 (perry) Aneesh Pradhan
2026-07-23 1:46 ` [PATCH v2 1/3] dt-bindings: arm: qcom: add " Aneesh Pradhan
2026-07-23 1:46 ` [PATCH v2 2/3] arm64: dts: qcom: add initial MSM8920 device tree Aneesh Pradhan
2026-07-23 1:46 ` [PATCH v2 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support Aneesh Pradhan
2026-07-23 2:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723013417.D5DFA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aneeshpradhan2004@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox