Re: [PATCH 1/2] ASoC: dt-bindings: es8316: Add regulator supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Variant-specific supply properties are defined globally, improperly allowing them for other incompatible hardware variants covered by the same binding.
--

--- Patch [1]: [PATCH 1/2] ASoC: dt-bindings: es8316: Add regulator supplies ---
commit d435f3d7346be3dbbefc6d1734447b71df8be5a3
Author: Hongyang Zhao <hongyang.zhao@thundersoft.com>

ASoC: dt-bindings: es8316: Add regulator supplies

The ES8316 has separate AVDD, CPVDD, DVDD and PVDD supply inputs
for its analog, charge pump, digital core and digital I/O domains.
Describe all four inputs so boards can model the codec power topology.

> diff --git a/Documentation/devicetree/bindings/sound/everest,es8316.yaml b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> index fe5d938ca3102..f45f59b7b0709 100644
> --- a/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> +++ b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> @@ -49,6 +49,18 @@ properties:
>      items:
>        - const: mclk
>  
> +  avdd-supply:
> +    description: Regulator providing the analog supply, from 2.0 V to 3.6 V
> +
> +  cpvdd-supply:
> +    description: Regulator providing the charge pump supply, from 1.6 V to 2.0 V

[Severity: Low]
Does defining this property globally inadvertently allow it for other
incompatible hardware variants covered by the same binding?

Since cpvdd-supply is defined at the global properties level, the schema
evaluates it as a valid optional property for all compatibles listed in the
file. This means if hardware variants like everest,es8311 and everest,es8323
lack a charge pump, the schema would silently accept cpvdd-supply in their
device tree nodes instead of properly rejecting it.

Should variant-specific supplies be guarded by an if:properties:compatible
conditional block to restrict them only to the hardware that actually supports
them?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-es8316-regulator-next-20260722-v1-0-721f757879a0@thundersoft.com?part=1