From: sashiko-bot@kernel.org
To: "Varadarajan Narayanan" <varadarajan.narayanan@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file
Date: Thu, 23 Jul 2026 09:17:08 +0000 [thread overview]
Message-ID: <20260723091710.87AE71F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723-08-dts-v3-2-074eb131f382@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit deletes `ipq5210-rdp504.dts` without removing its corresponding build target from the Makefile or introducing the promised replacement variant DTS files, which breaks the build pipeline.
--
--- Patch [2]: [PATCH v3 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file ---
commit 99961f95ec5ae7b25b1fb15a9e2cd99c99fc0456
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file
This commit renames the IPQ5210 RDP504 device tree file to a common .dtsi
file to allow sharing configurations between EMMC and NAND variants. It
also adds fixed USB regulators, PCIe reset GPIOs, and QPIC SPI NAND nodes.
> RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND
> share the GPIOs. The board has to be reworked to change from EMMC
> to NAND variant. Rename ipq5210-rdp504.dts as ipq5210-rdp504-common.dtsi
> and include it in variant specific DTS file.
[Severity: Low]
The commit message mentions including the new common file in variant-specific
DTS files, but it looks like those new variant .dts files were omitted from
this patch. Are they meant to be included here?
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts
> deleted file mode 100644
> index 941f866ecfe95..0000000000000
> --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts
> +++ /dev/null
[Severity: Low]
Does deleting this file without removing its entry from the Makefile cause a
build regression?
Kbuild will likely fail with a missing target error because
dtb-$(CONFIG_ARCH_QCOM) += ipq5210-rdp504.dtb appears to still be present in
arch/arm64/boot/dts/qcom/Makefile.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-08-dts-v3-0-074eb131f382@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-07-23 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 9:08 [PATCH v3 0/3] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan
2026-07-23 9:08 ` [PATCH v3 1/3] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan
2026-07-23 9:26 ` sashiko-bot
2026-07-23 9:08 ` [PATCH v3 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan
2026-07-23 9:17 ` sashiko-bot [this message]
2026-07-23 9:08 ` [PATCH v3 3/3] arm64: dts: qcom: ipq5210: Introduce RDP504 variant specific " Varadarajan Narayanan
2026-07-23 9:16 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723091710.87AE71F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox