Re: [PATCH v4 4/4] dt-bindings: leds: backlight: Convert TPS65217 to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The converted MFD (Multifunction Device) core binding is incorrectly placed in the `leds/backlight/` directory.
- [Low] The commit message uses an incorrect subsystem prefix for a Multifunction Device (PMIC).
--

--- Patch [4]: [PATCH v4 4/4] dt-bindings: leds: backlight: Convert TPS65217 to DT schema ---
commit 1f4c2bf543a28045151b5cf16c5be1f7c2cee8e1
Author: Eduard Bostina <egbostina@gmail.com>

dt-bindings: leds: backlight: Convert TPS65217 to DT schema

This commit converts the Texas Instruments TPS65217 bindings to DT schema.
It consolidates the old regulator and backlight bindings into a single
schema file while documenting additional child nodes and properties.

> dt-bindings: leds: backlight: Convert TPS65217 to DT schema

[Severity: Low]
Is the subsystem prefix correct for this device? The TPS65217 is a PMIC 
and its core driver resides in drivers/mfd/tps65217.c. Since this patch 
consolidates the bindings for a Multifunction Device into a single unified 
schema, should the prefix reflect the MFD subsystem instead, such as
dt-bindings: mfd: ti,tps65217:?

> diff --git a/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml b/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
> new file mode 100644
> index 0000000000000..4d2f4dbd2d52e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/ti,tps65217.yaml
> @@ -0,0 +1,170 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/ti,tps65217.yaml#

[Severity: Medium]
Since this schema consolidates the regulator, backlight, and other PMIC
functions into a single file, should this be placed in the mfd/ directory 
rather than leds/backlight/? Placing it in leds/backlight/ seems to 
categorize the device's primary role as a dedicated backlight rather than 
an MFD. If moved, the id and file path would become 
http://devicetree.org/schemas/mfd/ti,tps65217.yaml#.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723100605.628882-1-egbostina@gmail.com?part=4