From: sashiko-bot@kernel.org
To: "Francesco Dolcini" <francesco@dolcini.it>
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org,
imx@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter
Date: Thu, 23 Jul 2026 11:09:13 +0000 [thread overview]
Message-ID: <20260723110913.A77AB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723105225.194366-3-francesco@dolcini.it>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The standalone device tree overlay `imx7d-colibri-emmc-panel-cap-touch-7inch-parallel-touch-adapter.dtbo` is not added to the `dtb-$(CONFIG_SOC_IMX7D)` list in the Makefile, preventing it from being installed.
--
--- Patch [2]: [PATCH v1 2/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter ---
commit b48f5641aff3d40650a9c65a6f89f2a646bc3e83
Author: Francesco Dolcini <francesco.dolcini@toradex.com>
ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter
This commit adds a device tree overlay for the Capacitive Touch Display 7"
Parallel on the Colibri iMX7 parallel RGB LCD interface. It also combines
this overlay with the Eval carrier board device tree to provide a
ready-to-use DTB.
Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-7inch-parallel/
Link: https://developer.toradex.com/hardware/accessories/add-ons/capacitive-touch-adapter/
Link: https://docs.toradex.com/104615-capacitive-touch-adapter-datasheet.pdf [1]
> diff --git a/arch/arm/boot/dts/nxp/imx/Makefile b/arch/arm/boot/dts/nxp/imx/Makefile
> index 4d27300002025..3c16843c30714 100644
> --- a/arch/arm/boot/dts/nxp/imx/Makefile
> +++ b/arch/arm/boot/dts/nxp/imx/Makefile
[ ... ]
> @@ -437,6 +441,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \
> imx7d-colibri-emmc-iris-v2.dtb \
> imx7d-colibri-emmc-iris-v2-panel-cap-touch-7inch-parallel.dtb \
> imx7d-colibri-emmc-eval-v3.dtb \
> + imx7d-colibri-emmc-eval-v3-panel-cap-touch-7inch-parallel-touch-adapter.dtb \
> imx7d-colibri-emmc-panel-cap-touch-7inch-parallel.dtbo \
[Severity: Medium]
Should the standalone overlay
imx7d-colibri-emmc-panel-cap-touch-7inch-parallel-touch-adapter.dtbo also be
added to this dtb-$(CONFIG_SOC_IMX7D) list?
Without it, the standalone overlay will not be copied to the deployment
directory when running make dtbs_install, unlike the sibling overlay
imx7d-colibri-emmc-panel-cap-touch-7inch-parallel.dtbo which is present
just below. This might break the ability for users to apply the overlay
dynamically via U-Boot on other carrier boards.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723105225.194366-1-francesco@dolcini.it?part=2
next prev parent reply other threads:[~2026-07-23 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 10:52 [PATCH v1 0/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Displays 7" Parallel Francesco Dolcini
2026-07-23 10:52 ` [PATCH v1 1/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display " Francesco Dolcini
2026-07-23 10:52 ` [PATCH v1 2/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Capacitive Touch Display 7" Parallel with Touch Adapter Francesco Dolcini
2026-07-23 11:09 ` sashiko-bot [this message]
2026-07-23 10:52 ` [PATCH v1 3/3] ARM: dts: imx7d-colibri-emmc: Add Toradex Resistive Touch Display 7" Parallel Francesco Dolcini
2026-07-23 11:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723110913.A77AB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox