From: sashiko-bot@kernel.org
To: "Vincent Jardin" <vjardin@free.fr>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 1/3] hwmon: pmbus: event notification with alarms
Date: Thu, 23 Jul 2026 15:52:17 +0000 [thread overview]
Message-ID: <20260723155218.051381F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723-mpq8646_v0-v2-1-3c4cb71f23c0@free.fr>
> From: Vincent Jardin <vjardin@free.fr>
>
> Let's add an accessor for the hwmon class device the pmbus core
> registered for an i2c_client. Export it with PMBUS so chip
> drivers can call hwmon_notify_event() on per-sensor *_alarm
> attributes from the driver's work items.
>
> The needs: for boards when the chip's SMBALERT# pin is
> not available for the CPU, pmbus_irq_setup() cannot deliver
> poll(POLLPRI) wakes or udev change@... events on the inX_alarm
> files. So the drivers can install a delayed_work-based polling
> fallback (like the lm90 driver) that periodically reads STATUS_WORD
> and calls hwmon_notify_event() on 0->1 transitions.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-mpq8646_v0-v2-0-3c4cb71f23c0@free.fr?part=1
next prev parent reply other threads:[~2026-07-23 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 15:46 [PATCH v2 0/3] hwmon: pmbus: add MPS MPQ8646 support Vincent Jardin via B4 Relay
2026-07-23 15:46 ` [PATCH v2 1/3] hwmon: pmbus: event notification with alarms Vincent Jardin via B4 Relay
2026-07-23 15:52 ` sashiko-bot [this message]
2026-07-23 15:46 ` [PATCH v2 2/3] dt-bindings: hwmon: pmbus: add MPS MPQ8646 binding Vincent Jardin via B4 Relay
2026-07-23 15:53 ` sashiko-bot
2026-07-23 15:46 ` [PATCH v2 3/3] hwmon: pmbus: add MPQ8646 driver Vincent Jardin via B4 Relay
2026-07-23 16:07 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723155218.051381F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox