Re: [PATCH v2] dt-bindings: clock: ti,da850-pll: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML conversion fails to enforce the legacy binding requirement that `ti,da850-pll0` must have two clocks (`clksrc` and `extclksrc`).
--

--- Patch [1]: [PATCH v2] dt-bindings: clock: ti,da850-pll: Convert to DT schema ---
commit b42ff860694a3d7f4cabbc240cd8dff47c5f7fc0
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: clock: ti,da850-pll: Convert to DT schema
    
Convert TI da850-pll binding from legacy text to dt schema.

Link: https://lore.kernel.org/r/20260717-ti-pll-v1-1-f6f9ba8c9b5e@gmail.com

> diff --git a/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml b/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml
> new file mode 100644
> index 0000000000000..c6563290a702b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti/davinci/ti,da850-pll.yaml
[ ... ]
> +  clocks:
> +    minItems: 1
> +    items:
> +      - description: Primary reference clock input
> +      - description: External clock source
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: clksrc
> +      - const: extclksrc
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: ti,da850-pll1
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names:
> +          maxItems: 1
> +        ti,clkmode-square-wave: false
> +        auxclk: false

[Severity: Medium]
Does this conversion correctly enforce the legacy requirement for
ti,da850-pll0?

The text binding required two clocks (clksrc and extclksrc) for
ti,da850-pll0. While the allOf block correctly restricts ti,da850-pll1 to
maxItems: 1, it doesn't enforce minItems: 2 for ti,da850-pll0.

Could incomplete device tree nodes for ti,da850-pll0 with only one clock
silently pass schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-ti-pll-v2-1-cdc5e559a77d@gmail.com?part=1