Re: [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The command index `SM_LOAD_VIDEO_FW` is used in the command table but is never declared, resulting in a compilation error.
--

--- Patch [1]: [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call ---
commit 4e1de8a3e47aa991a20a91f21ed6881a59dc9c49
Author: Zhentao Guo <zhentao.guo@amlogic.com>

firmware: meson: sm: Add video firmware loading SMC call

This commit adds a new Secure Monitor Call (SMC) ID for loading video
firmware on Amlogic Meson chips.

> diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
> index ab9751a59b552..887caa5c625db 100644
> --- a/drivers/firmware/meson/meson_sm.c
> +++ b/drivers/firmware/meson/meson_sm.c
> @@ -48,6 +48,7 @@ static const struct meson_sm_chip gxbb_chip = {
>  		CMD(SM_THERMAL_CALIB_READ,	0x82000047),
>  		CMD(SM_A1_PWRC_SET,		0x82000093),
>  		CMD(SM_A1_PWRC_GET,		0x82000095),
> +		CMD(SM_LOAD_VIDEO_FW,		0xb200000f),

[Severity: Low]
Is SM_LOAD_VIDEO_FW declared anywhere? It looks like it was missed in the
command enum in include/linux/firmware/meson/meson_sm.h alongside the other
SM commands, which would cause a compilation error when building the driver.

>  		{ /* sentinel */ },
>  	},
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-b4-s4-vdec-upstream-v6-0-6072a7ee7428@amlogic.com?part=1