Re: [PATCH 3/3] dt-bindings: rtc: ti,omap-rtc: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The legacy text binding file `rtc-omap.txt` was not removed during the conversion to the new YAML DT schema.
- [Low] The schema unconditionally allows `system-power-controller` and `ext-wakeup` properties for all hardware variants, lacking required conditional constraints.
--

--- Patch [3]: [PATCH 3/3] dt-bindings: rtc: ti,omap-rtc: Convert to DT schema ---
commit d0c7ea3e6873301494678b3cfd1db8646ed9ff66
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: rtc: ti,omap-rtc: Convert to DT schema

Convert the Texas Instruments OMAP Real Time Clock (RTC) binding from
the legacy text format to the DT schema. Mark 'ti,hwmods' as deprecated
as it is no longer used, it is kept to support legacy boards.

> diff --git a/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml b/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml
> new file mode 100644
> index 0000000000000..eeea1bab65309
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml

[Severity: Low]
Should this conversion also delete the legacy text binding? It appears
Documentation/devicetree/bindings/rtc/rtc-omap.txt was left in the tree,
which leaves duplicate binding documentation.

> @@ -0,0 +1,129 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

[ ... ]

> +  interrupts:
> +    minItems: 2
> +    maxItems: 2
> +
> +  system-power-controller:
> +    type: boolean
> +    description:
> +      Indicates that this RTC controls system power via the pmic_power_en pin.

[Severity: Low]
Does this schema unconditionally allow system-power-controller for all
hardware variants?

For instance, the ti,da830-rtc variant doesn't appear to support PMIC mode.
Should there be an allOf / if-then block restricting this property to
ti,am3352-rtc and ti,am4372-rtc?

[ ... ]

> +  ti,hwmods:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Name of the hwmod associated with the RTC.
> +    const: rtc
> +    deprecated: true
> +
> +patternProperties:
> +  "^ext-wakeup(-[0-9]+)?$":
> +    type: object
> +
> +    description:
> +      Child node describing external wakeup pin configuration.

[Severity: Low]
Similar to the system-power-controller property, should this subnode also be
restricted to variants that support it? 

Without an allOf / if-then block, it seems device trees configured with
ext-wakeup for older hardware like ti,da830-rtc will silently pass schema
validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-ti-omap-rtc-v1-0-ffef78853cd6@gmail.com?part=3