From: sashiko-bot@kernel.org
To: "Varadarajan Narayanan" <varadarajan.narayanan@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file
Date: Fri, 24 Jul 2026 10:19:29 +0000 [thread overview]
Message-ID: <20260724101930.0C0EA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724-08-dts-v4-2-65e61a1061f0@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit deletes the original IPQ5210 RDP504 board DTS and its build target without simultaneously introducing the promised variant-specific replacement DTS files, dropping the board from the build and breaking bisection.
--
--- Patch [2]: [PATCH v4 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file ---
commit 82ed3dc795e1204be6951dec05e4b84f555d89db
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file
This commit splits the IPQ5210 RDP504 board configuration into a common
.dtsi file to prepare for eMMC and NAND variants. It also removes the
original board's dtb target from the Makefile.
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 6f33c4e2f09c3..4833c61e2da1e 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -24,7 +24,6 @@ dtb-$(CONFIG_ARCH_QCOM) += hamoa-iot-evk-el2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += hamoa-lenovo-ideacentre-mini-01q8x10.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp432-c2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq5018-tplink-archer-ax55-v1.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += ipq5210-rdp504.dtb
[Severity: Medium]
The commit message mentions renaming the file to a common .dtsi and
including it in a variant-specific DTS file. However, this patch removes
the dtb build target here without adding any new variant targets to replace it.
Will this drop the IPQ5210 RDP504 board from the build entirely and leave
the new ipq5210-rdp504-common.dtsi orphaned during bisection?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-08-dts-v4-0-65e61a1061f0@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-07-24 10:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 9:54 [PATCH v4 0/3] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan
2026-07-24 9:54 ` [PATCH v4 1/3] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan
2026-07-24 10:11 ` sashiko-bot
2026-07-24 9:54 ` [PATCH v4 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan
2026-07-24 10:19 ` sashiko-bot [this message]
2026-07-24 9:54 ` [PATCH v4 3/3] arm64: dts: qcom: ipq5210: Introduce RDP504 variant specific " Varadarajan Narayanan
2026-07-24 10:24 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724101930.0C0EA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox