Re: [PATCH v2 3/3] remoteproc: qcom: pas: Add Nord ADSP and CDSP support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect `crash_reason_smem` value for `nord_cdsp3_resource`.
--

--- Patch [3]: [PATCH v2 3/3] remoteproc: qcom: pas: Add Nord ADSP and CDSP support ---
commit e1a98d51f6d64eea0602e8e964394bba2b37262b
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

remoteproc: qcom: pas: Add Nord ADSP and CDSP support

This commit adds support for the ADSP and four CDSPs found on the Qualcomm 
Nord SoC. It configures the ADSP for early boot and sets up the necessary 
resource structures for all five DSPs.

> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 25599d7282083..6f3850a3fa9e8 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c

[ ... ]

> +static const struct qcom_pas_data nord_cdsp3_resource = {
> +	.crash_reason_smem = 666,

[Severity: Medium]
Is this SMEM item ID correct?

The sequence for the other CDSPs increases by 32:
nord_cdsp0_resource: 601
nord_cdsp1_resource: 633
nord_cdsp2_resource: 665

If that pattern holds, should this be 697 instead of 666?

Querying the wrong SMEM item ID will result in a failure to retrieve the 
crash reason when the CDSP3 remote processor crashes.

> +	.firmware_name = "cdsp3.mdt",
> +	.dtb_firmware_name = "cdsp3_dtb.mbn",
> +	.pas_id = 58,

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724103848.233804-1-shengchao.guo@oss.qualcomm.com?part=3