From: sashiko-bot@kernel.org
To: "Markus Probst" <markus.probst@posteo.de>
Cc: robh@kernel.org, lee@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, linux-leds@vger.kernel.org,
ojeda@kernel.org
Subject: Re: [PATCH v18 1/2] dt-bindings: embedded-controller: Add synology microp devices
Date: Fri, 24 Jul 2026 17:15:08 +0000 [thread overview]
Message-ID: <20260724171509.6BBA31F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724-synology_microp_initial-v18-1-fb2f49f10e77@posteo.de>
> Add the Synology Microp devicetree bindings. Those devices are
> microcontrollers found on Synology NAS devices. They are connected to a
> serial port on the host device.
>
> Those devices are used to control certain LEDs, fan speeds, a beeper, to
> handle buttons, fan failures and to properly shutdown and reboot the
> device.
>
> The device has a different feature set depending on the Synology NAS
> model, like having different number of fans, buttons and leds. Depending
> on the architecture of the model, they also need a different system
> shutdown behaviour.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Markus Probst <markus.probst@posteo.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-synology_microp_initial-v18-0-fb2f49f10e77@posteo.de?part=1
next prev parent reply other threads:[~2026-07-24 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 17:10 [PATCH v18 0/2] Introduce Synology Microp driver Markus Probst
2026-07-24 17:10 ` [PATCH v18 1/2] dt-bindings: embedded-controller: Add synology microp devices Markus Probst
2026-07-24 17:15 ` sashiko-bot [this message]
2026-07-24 17:10 ` [PATCH v18 2/2] platform: Add initial synology microp driver Markus Probst
2026-07-24 17:21 ` sashiko-bot
2026-07-24 17:35 ` Markus Probst
2026-07-24 18:41 ` [PATCH v18 0/2] Introduce Synology Microp driver Onur Özkan
2026-07-24 18:45 ` Markus Probst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724171509.6BBA31F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox