Re: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for Serdes port

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces PHY provider capabilities for the `airoha,en7581-scu` variant by adding the `#phy-cells` property, but fails to make it a required property for its compatible string and does not update the example.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: clock: airoha: Add PHY binding for Serdes port ---
commit 5719603a01527297dc730214337f813a27ac01a3
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: clock: airoha: Add PHY binding for Serdes port

This commit introduces a #phy-cells property for the airoha,en7581-scu
compatible string to support Serdes port selection. It also defines the
available Serdes ports in a new dt-bindings header file.

> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index eb24a5687639e..fc37786ac7ed8 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
[ ... ]
>    - if:
>        properties:
>          compatible:
> -          enum:
> -            - airoha,en7581-scu
> -            - econet,en751221-scu
> +          const: airoha,en7581-scu
>      then:
>        properties:
>          reg:

[Severity: Medium]
Should #phy-cells be added to a required list in this conditional block?

If the property is omitted for the airoha,en7581-scu hardware, device trees
will silently pass schema validation despite being incomplete, which can lead
to runtime failures when dependent drivers attempt to use the PHY functionality.

Additionally, does the airoha,en7581-scu example further down in the file need
to be updated with #phy-cells = <1>; to satisfy validation once the property
is required?

Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml:examples
      scuclk: clock-controller@1fb00000 {
        compatible = "airoha,en7581-scu";
        reg = <0x0 0x1fb00000 0x0 0x970>;
              #clock-cells = <1>;
              #reset-cells = <1>;
      };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724184304.192962-1-ansuelsmth@gmail.com?part=1