Re: [PATCH v2 3/3] dt-bindings: rtc: ti,omap-rtc: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing phandle label in the YAML example causing a dtc compilation error.
--

--- Patch [3]: [PATCH v2 3/3] dt-bindings: rtc: ti,omap-rtc: Convert to DT schema ---
commit 0cee4f860a851104188182b49417909d1f275491
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: rtc: ti,omap-rtc: Convert to DT schema

Convert the Texas Instruments OMAP Real Time Clock (RTC) binding from the
legacy text format to the DT schema. It also marks 'ti,hwmods' as deprecated
since it is no longer used.

> diff --git a/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml b/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml
> new file mode 100644
> index 0000000000000..326d5ad972922
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ti,omap-rtc.yaml

[ ... ]

> +  - |
> +    rtc@0 {
> +        compatible = "ti,am3352-rtc", "ti,da830-rtc";
> +        reg = <0x0 0x1000>;
> +        interrupts = <75>, <76>;
> +        system-power-controller;
> +        clocks = <&clk_32k_rtc>, <&clk_32768_ck>;
> +        clock-names = "ext-clk", "int-clk";
> +
> +        pinctrl-0 = <&ext_wakeup>;
> +        pinctrl-names = "default";
> +
> +        ext-wakeup {

[Severity: Low]
Will this cause a dtc compilation error during make dt_binding_check? 

The pinctrl-0 property above references <&ext_wakeup>, but it appears the 
label "ext_wakeup:" was dropped from this child node during the conversion 
from the text binding.

> +            pins = "ext_wakeup0";
> +            input-enable;
> +            ti,active-high;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260725-ti-omap-rtc-v2-0-13f765ca96b3@gmail.com?part=3