From: Bhargav Joshi <j.bhargav.u@gmail.com>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, goledhruva@gmail.com,
m-chawdhry@ti.com, daniel.baluta@gmail.com,
simona.toaca@nxp.com, j.bhargav.u@gmail.com
Subject: [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema
Date: Sun, 26 Jul 2026 00:17:47 +0530 [thread overview]
Message-ID: <20260726-ti-adpll-v1-1-86f6fc936507@gmail.com> (raw)
Convert the Texas Instruments DM814x ADPLL clock binding to DT schema
format. Add 'clock-output-names' as required which was missing in
legacy binding, as the driver (clk-adpll.c) mandates it and fails
probing if it is missing.
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
.../devicetree/bindings/clock/ti/adpll.txt | 39 --------
.../bindings/clock/ti/ti,dm814-adpll-clock.yaml | 108 +++++++++++++++++++++
2 files changed, 108 insertions(+), 39 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/ti/adpll.txt b/Documentation/devicetree/bindings/clock/ti/adpll.txt
deleted file mode 100644
index 3122360adcf3..000000000000
--- a/Documentation/devicetree/bindings/clock/ti/adpll.txt
+++ /dev/null
@@ -1,39 +0,0 @@
-Binding for Texas Instruments ADPLL clock.
-
-This binding uses the common clock binding[1]. It assumes a
-register-mapped ADPLL with two to three selectable input clocks
-and three to four children.
-
-[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Required properties:
-- compatible : shall be one of "ti,dm814-adpll-s-clock" or
- "ti,dm814-adpll-lj-clock" depending on the type of the ADPLL
-- #clock-cells : from common clock binding; shall be set to 1.
-- clocks : link phandles of parent clocks clkinp and clkinpulow, note
- that the adpll-s-clock also has an optional clkinphif
-- reg : address and length of the register set for controlling the ADPLL.
-
-Examples:
- adpll_mpu_ck: adpll@40 {
- #clock-cells = <1>;
- compatible = "ti,dm814-adpll-s-clock";
- reg = <0x40 0x40>;
- clocks = <&devosc_ck &devosc_ck &devosc_ck>;
- clock-names = "clkinp", "clkinpulow", "clkinphif";
- clock-output-names = "481c5040.adpll.dcoclkldo",
- "481c5040.adpll.clkout",
- "481c5040.adpll.clkoutx2",
- "481c5040.adpll.clkouthif";
- };
-
- adpll_dsp_ck: adpll@80 {
- #clock-cells = <1>;
- compatible = "ti,dm814-adpll-lj-clock";
- reg = <0x80 0x30>;
- clocks = <&devosc_ck &devosc_ck>;
- clock-names = "clkinp", "clkinpulow";
- clock-output-names = "481c5080.adpll.dcoclkldo",
- "481c5080.adpll.clkout",
- "481c5080.adpll.clkoutldo";
- };
diff --git a/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
new file mode 100644
index 000000000000..7f551dfca030
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/ti/ti,dm814-adpll-clock.yaml
@@ -0,0 +1,108 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/ti/ti,dm814-adpll-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DM814x ADPLL Clock
+
+maintainers:
+ - Tony Lindgren <tony@atomide.com>
+
+description:
+ The ADPLL is a register-mapped clock generator found on TI DM814x SoCs. It
+ provides multiple output clocks from two or three selectable input clocks and
+ three to four children.
+
+properties:
+ compatible:
+ enum:
+ - ti,dm814-adpll-s-clock
+ - ti,dm814-adpll-lj-clock
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+ clocks:
+ minItems: 2
+ maxItems: 3
+
+ clock-names:
+ minItems: 2
+ maxItems: 3
+
+ clock-output-names:
+ minItems: 3
+ maxItems: 4
+
+required:
+ - compatible
+ - reg
+ - '#clock-cells'
+ - clocks
+ - clock-output-names
+
+if:
+ properties:
+ compatible:
+ contains:
+ const: ti,dm814-adpll-s-clock
+then:
+ properties:
+ clocks:
+ minItems: 3
+ clock-names:
+ items:
+ - const: clkinp
+ - const: clkinpulow
+ - const: clkinphif
+ clock-output-names:
+ items:
+ - description: dcoclkldo
+ - description: clkout
+ - description: clkoutx2
+ - description: clkouthif
+else:
+ properties:
+ clocks:
+ maxItems: 2
+ clock-names:
+ items:
+ - const: clkinp
+ - const: clkinpulow
+ clock-output-names:
+ items:
+ - description: dcoclkldo
+ - description: clkout
+ - description: clkoutldo
+
+additionalProperties: false
+
+examples:
+ - |
+ adpll@40 {
+ compatible = "ti,dm814-adpll-s-clock";
+ reg = <0x40 0x40>;
+ #clock-cells = <1>;
+ clocks = <&devosc_ck &devosc_ck &devosc_ck>;
+ clock-names = "clkinp", "clkinpulow", "clkinphif";
+ clock-output-names = "481c5040.adpll.dcoclkldo",
+ "481c5040.adpll.clkout",
+ "481c5040.adpll.clkoutx2",
+ "481c5040.adpll.clkouthif";
+ };
+
+ - |
+ adpll@80 {
+ compatible = "ti,dm814-adpll-lj-clock";
+ reg = <0x80 0x30>;
+ #clock-cells = <1>;
+ clocks = <&devosc_ck &devosc_ck>;
+ clock-names = "clkinp", "clkinpulow";
+ clock-output-names = "481c5080.adpll.dcoclkldo",
+ "481c5080.adpll.clkout",
+ "481c5080.adpll.clkoutldo";
+ };
---
base-commit: 0ce37745d4bfbc493f718169c3974898ffec8ee7
change-id: 20260725-ti-adpll-ddfd84e4ef18
Best regards,
--
Bhargav
next reply other threads:[~2026-07-25 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 18:47 Bhargav Joshi [this message]
2026-08-03 21:50 ` [PATCH] dt-bindings: clock: ti,DM814x-ADPLL: Convert to DT schema Rob Herring
2026-08-04 18:29 ` Bhargav Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726-ti-adpll-v1-1-86f6fc936507@gmail.com \
--to=j.bhargav.u@gmail.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=goledhruva@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=simona.toaca@nxp.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox