Re: [PATCH 7/9] dtc: dt-check-style: Consistently call 'kind' as 'file_type'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Blind search-and-replace corrupted the docstring for `_natural_sort_key`.
--

--- Patch [7]: [PATCH 7/9] dtc: dt-check-style: Consistently call 'kind' as 'file_type' ---
commit 8e2fd209c720e5544c185a9ec09b15945051b1cb
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Consistently call 'kind' as 'file_type'

Script was using different names for variables or attributes with the
same meaning: the type of file (YAML, DTS, DTSI, DTSO).  Unify 'kind',
'input_kind' and function input_kind() to consistent 'file_type'.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 171a5e12fcbd8..8c049c04b865c 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style

[ ... ]

> @@ -519,7 +519,7 @@ def _walk_bodies(lines):
>  
>  
>  def _natural_sort_key(s):
> -    """Split a string into a tuple of (kind, value) pairs that compares
> +    """Split a string into a tuple of (file_type, value) pairs that compares
>      numeric runs as ints, so 'foo10' sorts after 'foo2'."""
>      parts = []
>      for part in re.split(r'(\d+)', s):

[Severity: Low]
Does the docstring still accurately describe the return value of
_natural_sort_key()?

It looks like the global rename changed 'kind' to 'file_type' here, but in
this context, 'kind' referred to the type of the split part (numeric or
string) for natural sorting, rather than the type of file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260726-n-dts-style-checker-continued-v1-0-b05b8f897670@oss.qualcomm.com?part=7