From: sashiko-bot@kernel.org
To: "Alberto Robazza" <robazzalberto@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org,
neil.armstrong@linaro.org, conor+dt@kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: vendor-prefixes: add Orbbec
Date: Sun, 26 Jul 2026 18:24:46 +0000 [thread overview]
Message-ID: <20260726182446.E24501F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260726182158.249449-2-robazzalberto@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new vendor prefix 'orbbec' is inserted out of alphabetical order.
--
--- Patch [1]: [PATCH 1/3] dt-bindings: vendor-prefixes: add Orbbec ---
commit 55024190d5a9225c41b52b0372720d44cc6a4378
Author: Alberto Robazza <robazza.alberto@proton.me>
dt-bindings: vendor-prefixes: add Orbbec
This commit adds the "orbbec" vendor prefix for Orbbec Inc., which is
needed to support an upcoming board compatible string.
Link: https://www.orbbec.com/
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 396044f368e7c..f205df64a0a89 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1213,6 +1213,8 @@ patternProperties:
> description: Orient Chip Technology Co., Ltd.
> "^oct,.*":
> description: Octavo Systems LLC
> + "^orbbec,.*":
> + description: Orbbec Inc.
[Severity: Low]
This isn't a bug, but it appears the new vendor prefix was inserted out of
alphabetical order before okaya. Should orbbec be moved further down the
list to maintain the file's sorting convention?
> "^okaya,.*":
> description: Okaya Electric America, Inc.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260726182158.249449-1-robazzalberto@gmail.com?part=1
next prev parent reply other threads:[~2026-07-26 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 18:21 [PATCH 0/3] arm64: dts: amlogic: add support for Orbbec Zora P1 Alberto Robazza
2026-07-26 18:21 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add Orbbec Alberto Robazza
2026-07-26 18:24 ` sashiko-bot [this message]
2026-07-26 18:21 ` [PATCH 2/3] dt-bindings: arm: amlogic: document Orbbec Zora P1 board compatible Alberto Robazza
2026-07-26 18:21 ` [PATCH 3/3] arm64: dts: amlogic: add support for Orbbec Zora P1 Alberto Robazza
2026-07-26 18:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726182446.E24501F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robazzalberto@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox