Re: [PATCH v8 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree schema incorrectly allows `bus-type` to be configured as C-PHY (1) for `ite,it6625` devices, which only support D-PHY (4).
--

--- Patch [1]: [PATCH v8 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge ---
commit fa0e1ae27e2934f8fdb2a29be488c42a9ccd6645
Author: Hermes Wu <Hermes.wu@ite.com.tw>

dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge

Document the devicetree binding for the ITE IT6625/IT6626 HDMI to
MIPI CSI-2 bridge. The device exposes two graph ports and supports
split or clone mode.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
> new file mode 100644
> index 0000000000000..756fe655f534f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
[ ... ]
> +      port@0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: CSI-2 output port MIPI0
> +
> +        properties:
> +          endpoint:
> +            $ref: /schemas/media/video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +              bus-type:
> +                enum:
> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ite,it6626
> +    then:
> +      properties:
> +        ports:
> +          properties:
> +            port@0:
> +              properties:
> +                endpoint:
> +                  required:
> +                    - bus-type

[Severity: Medium]
The patch notes mention dropping the allOf branch that forces bus-type to 
const 4 for ite,it6625 because the value is implied by the compatible string.
Does removing this constraint prevent the schema from verifying the hardware
limitations?

Since the base endpoint property allows both C-PHY (1) and D-PHY (4) globally,
if a devicetree author explicitly adds bus-type = <1> to an ite,it6625 node,
wouldn't the schema silently pass validation even though the hardware only 
supports D-PHY?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-upstream-it6625-it6626-v8-0-2c3b0f9524fc@ite.com.tw?part=1