Re: [PATCH v5 1/3] soc: qcom: smem: Use 'unsigned int' instead of 'unsigned'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete conversion from 'unsigned' to 'unsigned int' leaves header and source file inconsistent.
--

--- Patch [1]: [PATCH v5 1/3] soc: qcom: smem: Use 'unsigned int' instead of 'unsigned' ---
commit 936d065428d0ec1f3bef2d47e4d7642e78104f77
Author: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

soc: qcom: smem: Use 'unsigned int' instead of 'unsigned'

This commit converts the SMEM driver to use the 'unsigned int' type instead
of bare 'unsigned'. This is intended to resolve a checkpatch warning about
preferring less ambiguous types.

> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index afb21a778fe7b..43b66120fc644 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
[ ... ]
> @@ -503,7 +503,7 @@ static int qcom_smem_alloc_global(struct qcom_smem *smem,
>   *
>   * Return: 0 on success, negative errno on failure.
>   */
> -int qcom_smem_alloc(unsigned host, unsigned item, size_t size)
> +int qcom_smem_alloc(unsigned int host, unsigned int item, size_t size)

[Severity: Low]
Should the function declarations in include/linux/soc/qcom/smem.h also be
updated to match these new definitions?

The public header still declares qcom_smem_alloc(), qcom_smem_get(), and 
qcom_smem_get_free_space() using bare unsigned types. Updating the header
as well would keep the API consistent and fully resolve the checkpatch
warnings for users of the header.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-topic-smem_dramc-v5-0-66188b3e338d@oss.qualcomm.com?part=1