Re: [PATCH v6 5/5] arm64: dts: imx8mp-skov: support new 7inch panel board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing touch controller node in the device tree overlay.
--

--- Patch [5]: [PATCH v6 5/5] arm64: dts: imx8mp-skov: support new 7inch panel board ---
commit bd24f58ff22bbd1df246534579e3ab608027e17c
Author: Steffen Trumtrar <s.trumtrar@pengutronix.de>

arm64: dts: imx8mp-skov: support new 7inch panel board

This commit adds a device tree overlay for the SKOV IMX8MP CPU revC board
paired with a 7-inch JuTouch JT070TM041 panel. It also updates the Makefile
to compile the new overlay and device tree binaries.

[ ... ]

> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso
> new file mode 100644
> index 0000000000000..20e987b36c53a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revc-jutouch-jt070tm041.dtso
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&{/} {
> +	model = "SKOV IMX8MP CPU revC - JuTouch JT070TM041";
> +	compatible = "skov,imx8mp-skov-revc-jutouch-jt070tm041", "fsl,imx8mp";
> +
> +	panel {
> +		compatible = "jutouch,jt070tm041";
> +		backlight = <&backlight>;
> +		power-supply = <&reg_tft_vcom>;
> +
> +		port {
> +			in_lvds0: endpoint {
> +				remote-endpoint = <&ldb_lvds_ch0>;
> +			};
> +		};
> +	};
> +};

[Severity: Medium]
The commit message mentions that this board uses a different 7-inch panel
with a different touch controller. However, there doesn't appear to be a node
configuring the touch controller itself in this overlay. 

Is the touch controller hardware configuration missing from this file, or is
the touchscreen initialization handled outside of this device tree overlay?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-v7-0-topic-imx8mp-skov-dts-jutouch-7inch-v6-0-fa8f71dfc56f@pengutronix.de?part=5