From: sashiko-bot@kernel.org
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
wsa+renesas@sang-engineering.com
Subject: Re: [PATCH 1/2] dt-bindings: i2c: rcar-i2c: Document R-Car X5H support
Date: Mon, 27 Jul 2026 11:40:40 +0000 [thread overview]
Message-ID: <20260727114041.303811F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260727113441.11193-5-wsa+renesas@sang-engineering.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new `renesas,rcar-gen5-i2c` compatible string is missing from the `allOf` conditional block that requires the `resets` property, resulting in a Device Tree schema validation bypass.
--
--- Patch [1]: [PATCH 1/2] dt-bindings: i2c: rcar-i2c: Document R-Car X5H support ---
commit e3abab1fc2392666638c3324ed628bfe91397742
Author: Minh Le <minh.le.aj@renesas.com>
dt-bindings: i2c: rcar-i2c: Document R-Car X5H support
This commit adds documentation for the rcar-i2c on R8A78000 (X5H) SoCs.
It introduces the new Gen5 compatible strings.
> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
> index 6cc60c3f61cd6..46b4bd16c5937 100644
> --- a/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml
> @@ -56,6 +56,11 @@ properties:
> - renesas,i2c-r8a779h0 # R-Car V4M
> - const: renesas,rcar-gen4-i2c # R-Car Gen4
>
> + - items:
> + - enum:
> + - renesas,i2c-r8a78000 # R-Car X5H
> + - const: renesas,rcar-gen5-i2c # R-Car Gen5
[Severity: Medium]
Will this schema fully validate the new hardware configurations?
The new renesas,rcar-gen5-i2c string is defined here, but the allOf
conditional block for the resets property lower in the file only matches
Gen2, Gen3, and Gen4:
- if:
properties:
compatible:
contains:
enum:
- renesas,rcar-gen2-i2c
- renesas,rcar-gen3-i2c
- renesas,rcar-gen4-i2c
then:
required:
- resets
Should renesas,rcar-gen5-i2c be added to this enum list so that missing reset
configurations are still caught by dt_binding_check?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727113441.11193-4-wsa+renesas@sang-engineering.com?part=1
next prev parent reply other threads:[~2026-07-27 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 11:34 [PATCH 0/2] i2c: rcar: add Gen5 support Wolfram Sang
2026-07-27 11:34 ` [PATCH 1/2] dt-bindings: i2c: rcar-i2c: Document R-Car X5H support Wolfram Sang
2026-07-27 11:40 ` sashiko-bot [this message]
2026-07-27 11:48 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727114041.303811F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox