Re: [PATCH v4 13/16] ARM: dts: microchip: sama7d65: add otpc node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added `temperature_calib` NVMEM cell is not referenced by the `adc` node, causing the ADC driver to silently skip temperature sensor initialization.
- [Low] The `<dt-bindings/nvmem/microchip,sama7g5-otpc.h>` header is included but completely unused.
--

--- Patch [13]: [PATCH v4 13/16] ARM: dts: microchip: sama7d65: add otpc node ---
commit dd1db22ae5d7132965b472e571b6275cf5176e96
Author: Varshini Rajendran <varshini.rajendran@microchip.com>

ARM: dts: microchip: sama7d65: add otpc node
    
Add OTPC node along with temperature calibration cell.

> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index c35f27615bc49..aac2e22d96cb3 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -15,6 +15,7 @@
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/mfd/at91-usart.h>
> +#include <dt-bindings/nvmem/microchip,sama7g5-otpc.h>

[Severity: Low]
This isn't a bug, but should this header be included? It doesn't appear
to be used in this file, as the calibration cell uses a TAG-based NVMEM
access instead of the OTP_PKT() macro provided by this header.

>  
>  / {
>  	model = "Microchip SAMA7D65 family SoC";
> @@ -1111,6 +1112,21 @@ ddr3phy: ddr3phy@e3804000 {
>  			reg = <0xe3804000 0x1000>;
>  		};
>  
> +		otpc: efuse@e8c00000 {
> +			compatible = "microchip,sama7d65-otpc", "microchip,sama7g5-otpc", "syscon";
> +			reg = <0xe8c00000 0x100>;
> +
> +			nvmem-layout {
> +				compatible = "fixed-layout";
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +
> +				temperature_calib: calib@41435354 {
> +					reg = <0x41435354 0x2c>;	/* Temp calib data packet TAG */
> +				};

[Severity: Medium]
Should the adc@e1000000 node be updated to reference this newly added cell?
Without 'nvmem-cells = <&temperature_calib>;' and
'nvmem-cell-names = "temperature_calib";' properties in the adc node, the ADC
driver will silently skip temperature sensor initialization when it receives
-ENOENT from nvmem_cell_get().

> +			};
> +		};
> +
>  		gic: interrupt-controller@e8c11000 {
>  			compatible = "arm,cortex-a7-gic";
>  			reg = <0xe8c11000 0x1000>,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727122633.117435-1-varshini.rajendran@microchip.com?part=13