Re: [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing deletion of hardware blocks and thermal zones specific to the removed CPU cluster 0 (e.g., `bwmon_cluster0`, thermal zones), leading to a fatal SError and spurious thermal shutdowns.
--

--- Patch [2]: [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC ---
commit d6b5f610923793ce8197e8297bbc2ded9a915289
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

arm64: dts: qcom: Add Kalambo SoC

This commit introduces support for the Qualcomm Kalambo SoC, which is
derived from Mahua but has CPU cluster 0 removed. It reassigns the surviving
cluster as cluster0 in the cpu-map and overrides memory offsets for imem.

> diff --git a/arch/arm64/boot/dts/qcom/kalambo.dtsi b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> new file mode 100644
> index 0000000000000..4a68115a4286a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> @@ -0,0 +1,97 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include "mahua.dtsi"
> +
> +/delete-node/ &cluster0_pd;
> +/delete-node/ &cpu_map;
> +/delete-node/ &cpu0;

[Severity: High]
Does this also need to delete the associated bwmon_cluster0 node and the
cluster 0 thermal zones (like cpu-0-0-0-thermal and qmx-0-0-thermal)?

Because bwmon_cluster0 lacks a power domain dependency in the base device
tree, the icc-bwmon driver might unconditionally probe it. On Qualcomm SoCs,
attempting to map and access the MMIO registers of a physically removed
hardware block typically triggers a bus timeout and a fatal asynchronous
SError during boot.

Additionally, will leaving the cluster 0 thermal zones active cause them to
poll non-existent tsens sensors? If so, this could return garbage maximum
values and trigger an immediate emergency thermal shutdown.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-b4-kalambo-crd-v3-0-25280faceece@oss.qualcomm.com?part=2