Re: [RESEND V2 1/2] dt-bindings: pinctrl: tegra264: fix DAP2 DIN/DOUT pin names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The dt-bindings update renames the pins dap2_din_pv7 and dap2_dout_pw0 to dap2_din_pw0 and dap2_dout_pv7, but fails to update the corresponding string names in the pinctrl driver, breaking device tree parsing at runtime.
--

--- Patch [1]: [RESEND V2 1/2] dt-bindings: pinctrl: tegra264: fix DAP2 DIN/DOUT pin names ---
commit 467f2064204e431cbe2d5bcbda6fbbde377327d8
Author: Prathamesh Shete <pshete@nvidia.com>

dt-bindings: pinctrl: tegra264: fix DAP2 DIN/DOUT pin names

This commit corrects the ball suffixes for the DAP2 DIN and DOUT pins in the
Tegra264 pinctrl dt-bindings. It renames dap2_din_pv7 and dap2_dout_pw0 to
dap2_din_pw0 and dap2_dout_pv7 in both the pin properties and drive groups.

> diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml
> index c40409d3263c2..01db762e82bc0 100644
> --- a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra264-pinmux-main.yaml
> @@ -44,7 +44,7 @@ patternProperties:
>                      soc_gpio173_pu3, soc_gpio174_pu4, soc_gpio175_pu5,
>                      soc_gpio176_pu6, soc_gpio177_pu7, soc_gpio178_pv0,
>                      pwm10_pv1, uart4_tx_pv2, uart4_rx_pv3, uart4_rts_n_pv4,
> -                    uart4_cts_n_pv5, dap2_clk_pv6, dap2_din_pv7, dap2_dout_pw0,
> +                    uart4_cts_n_pv5, dap2_clk_pv6, dap2_din_pw0, dap2_dout_pv7,

[Severity: High]
Does this change break device tree parsing at runtime?

While the binding is updated to enforce the correct pin names, it appears the
corresponding pinctrl driver was not updated to match.

Looking at tegra264_main_groups() in drivers/pinctrl/tegra/pinctrl-tegra264.c,
the driver still registers the pin groups using the old names:

    PINGROUP(dap2_din_pv7, I2S2_SDATA_OUT, RSVD1, RSVD2, RSVD3, 0x6050, ...
    PINGROUP(dap2_dout_pw0, I2S2_SDATA_IN, RSVD1, RSVD2, RSVD3, 0x6058, ...

Because the binding now requires dap2_din_pw0 and dap2_dout_pv7, device trees
adhering to the new binding will fail to match the driver's string identifiers.

Will this cause the pinctrl core to fail to configure the DAP2 interface
because it cannot find the updated names in the driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727141121.772110-1-pshete@nvidia.com?part=1