Re: [PATCH v9 5/6] arm64: dts: qcom: Add AYN Odin 2 Portal

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Fixed regulator nodes use a deprecated naming convention that will trigger devicetree validation warnings.
--

--- Patch [5]: [PATCH v9 5/6] arm64: dts: qcom: Add AYN Odin 2 Portal ---
commit 0ad21da21b369d77d78a0eaf792c099796b2fd81
Author: Teguh Sobirin <teguh@sobir.in>

arm64: dts: qcom: Add AYN Odin 2 Portal

This patch adds devicetree support for the AYN Odin 2 Portal, a handheld
gaming console powered by the Qualcomm Snapdragon 8 Gen 2 processor.

> diff --git a/arch/arm64/boot/dts/qcom/qcs8550-ayntec-odin2portal.dts b/arch/arm64/boot/dts/qcom/qcs8550-ayntec-odin2portal.dts
> new file mode 100644
> index 0000000000000..2c6e63f47cceb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs8550-ayntec-odin2portal.dts
[ ... ]
> +&{/} {
> +	model = "AYN Odin 2 Portal";
> +	compatible = "ayntec,odin2portal", "qcom,qcs8550", "qcom,sm8550";
> +
> +	vdd_bl_5v0: vdd-bl-5v0-regulator {

[Severity: Low]
Will this node name trigger devicetree validation warnings? Fixed regulators
typically use a regulator-* prefix rather than a -regulator suffix to comply
with the devicetree specification. Could this be named regulator-vdd-bl-5v0
instead?

> +		compatible = "regulator-fixed";
> +		regulator-name = "vdd_bl_5v0";
> +
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +
> +		gpio = <&tlmm 52 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
> +	vdd_disp_2v8: vdd-disp-2v8-regulator {

[Severity: Low]
Similar to above, will this trigger a dtbs_check warning due to the -regulator
suffix? Should this be regulator-vdd-disp-2v8 to match the generic node name
expectations?

> +		compatible = "regulator-fixed";
> +		regulator-name = "vdd_disp_2v8";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-ayn-qcs8550-v9-0-e3db456e10e5@gmail.com?part=5