Re: [PATCH v1 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example uses a deprecated compatible string 'synopsys,dwc3' for the child DWC3 node.
--

--- Patch [1]: [PATCH v1 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller ---
commit 716289e3efcde452eab06f93d71e6ed140cbc0c3
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>

dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller

This commit adds documentation for the Renesas R-Car Gen5 DWC3 xHCI USB
controller and its glue logic wrapper. It defines a new YAML binding schema
that references the core snps,dwc3.yaml schema.

> diff --git a/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-usb.yaml b/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-usb.yaml
> new file mode 100644
> index 0000000000000..a334648e2dfc4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/renesas,rcar-gen5-usb.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    bus {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        usb@c9c54000 {
> +            compatible = "renesas,r8a78000-usb", "renesas,rcar-gen5-usb";

[ ... ]

> +            ranges = <0x0 0xc8800000 0x0 0xc8800000 0x0 0x100000>;
> +
> +            usb@c8800000 {
> +                compatible = "synopsys,dwc3";

[Severity: Low]
This isn't a bug, but the example uses the deprecated compatible string
"synopsys,dwc3" for the child DWC3 node. The base schema snps,dwc3.yaml
explicitly marks this as deprecated in favor of "snps,dwc3".

Should this be updated to avoid triggering warnings during schema validation
and to prevent users from copying outdated patterns into new device trees?

> +                reg = <0x0 0xc8800000 0x0 0x100000>;
> +                interrupts = <GIC_SPI 795 IRQ_TYPE_LEVEL_HIGH>;
> +                maximum-speed = "super-speed-plus";
> +                phys = <&mp_phy 2>;
> +                phy-names = "usb3-phy";
> +            };
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728011656.465040-1-marek.vasut+renesas@mailbox.org?part=1