Re: [PATCH v4 2/2] soc/tegra: pmc: Add Tegra210B01 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented behavioral change disabling the MBIST workaround (`needs_mbist_war = false`) for Tegra210B01.
--

--- Patch [2]: [PATCH v4 2/2] soc/tegra: pmc: Add Tegra210B01 support ---
commit 86284ce805fe44e2007af5f83c9d15e2c0fd40d2
Author: Alexandre Hamamdjian <azkali.limited@gmail.com>

soc/tegra: pmc: Add Tegra210B01 support

This commit adds power management controller support for the Tegra210B01 
stepping. The commit message notes it is similar to the original Tegra210 
but removes the sata and ve2 powergates.

> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index f419a5395545f..685b2b0f975c3 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
[ ... ]
> @@ -3897,6 +3897,67 @@ static const struct tegra_pmc_soc tegra210_pmc_soc = {
>  	.has_single_mmio_aperture = true,
>  };
>  
> +static const char * const tegra210b01_powergates[] = {
[ ... ]
> +};
> +
> +static const struct tegra_pmc_soc tegra210b01_pmc_soc = {
> +	.supports_core_domain = false,
> +	.num_powergates = ARRAY_SIZE(tegra210b01_powergates),
> +	.powergates = tegra210b01_powergates,
> +	.num_cpu_powergates = ARRAY_SIZE(tegra210_cpu_powergates),
> +	.cpu_powergates = tegra210_cpu_powergates,
> +	.has_tsense_reset = true,
> +	.has_gpu_clamps = true,
> +	.needs_mbist_war = false,
[Severity: Medium]
The commit message mentions that sata and ve2 are removed, but does not
mention disabling the MBIST workaround. Is this an intentional hardware
fix for the B01 stepping, or was this field accidentally set to false
compared to the original tegra210_pmc_soc?

If it's an intentional change, could the commit message be updated to
reflect this difference from the original Tegra210?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-t210b01-pmc-v4-0-af68a21cd746@gmail.com?part=2